MARC21slim2MADS.xsl error processing 755 source

Bug #1800871 reported by Josh Stompro on 2018-10-31
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

EG Version: 3.0

The MARC21slim2MADS.xsl definition seems to have a bug that doesn't allow 755 field data to be processed when a source is specified.

The error is "runtime error: file ./MARC21slim2MADS.xsl line 1404 element attribute
xsl:attribute: Cannot add attributes to an element if children have been already added to the element."

See the discussion on the listserv at:
https://georgialibraries.markmail.org/thread/rmwcxkwjzv2qczmu

It looks like the issue may be that the setAuthority template is being called before the genre template, and that the genre template also calls the setAuthority template.

Removing the setAuthority template call from the 755 tag processing section seems to fix the issue.

If this is the issue then it needs to be fixed locally in Evergreen by updating the MARC21slim2MADS.xsl file, along with the copy that resides in the database.

It should also be reported upstream to the MODS listserve.

Using MADS to process authorities was introduced in version 3.0, so it may need to be backported that far.. although it isn't a security issue, so that may not be allowed. This can cause a roadblock when sites upgrade by causing the authority reingest in the 3.0 upgrade scripts to fail.

Linda Jansova provided an example of an authority that was hitting the error in her initial email about the problem.

Josh

Linda Jansova (skolkova-s) wrote :

The official file from the LC has already been updated accordingly:

-------- Forwarded Message --------
Subject: Re: [MODS] MARCXML to MADS XSLT - 2.15 revision
Date: Tue, 13 Nov 2018 21:49:04 +0000
From: Meehleib, Tracy <email address hidden>
Reply-To: Metadata Object Description Schema List <email address hidden>
To: <email address hidden>

Hi Linda,

The MARCXML to MADS XSLT has been updated and uploaded. Please let me know if you have any other issues with it. Apologies for the slow turnaround--we had server/network issues here at LC last week.

< http://www.loc.gov/standards/marcxml/xslt/MARC21slim2MADS.xsl>

Best, Tracy

Tracy Meehleib
Network Development and MARC Standards Office
Library of Congress
101 Independence Ave SE
Washington, DC 20540-4402
+1 202 707 0121 (voice)
+1 202 707 0115 (fax)
<email address hidden>

Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
status: New → In Progress
tags: added: authority

Hello, I've taken a stab at updating the evergreen files related to this.

It is a pretty simple change, only 2 lines, one changelog line, and then moving two lines around.

Branch at user/stompro/lp1800871_MADS_2.15_update

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1800871_MADS_2.15_update

Josh

tags: added: pullrequest
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
status: In Progress → Confirmed
Linda Jansova (skolkova-s) wrote :

Thank you, Josh!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers