SIP2 payments with payment type 01 ("VISA") are recorded as cash

[Jeff Godin]

The SIP2 standard defines three payment types:

00 - cash
01 - VISA
02 - credit card

Currently, Evergreen only treats payment type 02 as a "credit card payment" and all others as cash.

We have seen SIP2 client software that passes payment type 01 (VISA) for all credit card payments (even non-VISA card payments).

Evergreen should record SIP2 payment type 01 as a credit card payment, not a cash payment.

Discovered and patched locally some time ago, then re-discovered (and realized that there was no bug or branch submitted).

Previously: http://irc.evergreen-ils.org/evergreen/2015-07-31#i_192807

[Jeff Godin (jgodin)]

working branch at user/jeff/lp1796942_sip_payment_type_01_visa

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/lp1796942_sip_payment_type_01_visa

[Galen Charlton (gmc)]

Signed off:

working/user/gmcharlt/lp1796942_signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1796942_signoff

[Bill Erickson (berick)]

Looks good, thanks Jeff, Galen. Merged to 3.1 and above.