SIP2 payments with payment type 01 ("VISA") are recorded as cash

Bug #1796942 reported by Jeff Godin on 2018-10-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned
3.2
Undecided
Unassigned

Bug Description

The SIP2 standard defines three payment types:

00 - cash
01 - VISA
02 - credit card

Currently, Evergreen only treats payment type 02 as a "credit card payment" and all others as cash.

We have seen SIP2 client software that passes payment type 01 (VISA) for all credit card payments (even non-VISA card payments).

Evergreen should record SIP2 payment type 01 as a credit card payment, not a cash payment.

Discovered and patched locally some time ago, then re-discovered (and realized that there was no bug or branch submitted).

Previously: http://irc.evergreen-ils.org/evergreen/2015-07-31#i_192807

Jeff Godin (jgodin) wrote :
Changed in evergreen:
milestone: none → 3.1.7
milestone: 3.1.7 → 3.2.1
no longer affects: evergreen/3.2
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Remington Steed (rjs7) on 2018-11-26
tags: added: pullrequest
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Galen Charlton (gmc) wrote :
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
tags: added: signedoff
Bill Erickson (berick) wrote :

Looks good, thanks Jeff, Galen. Merged to 3.1 and above.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers