Be more strategic about autofocus usage in the OPAC
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Currently, the following pages autofocus on the search box, even though searching is not the purpose of the page:
* https:/
* https:/
* https:/
* https:/
* https:/
This is problematic from an accessibility perspective, see the following:
* https:/
* https:/
I think this could be easily fixed by changing this line to check that is_home_page is true as well as basic_search != "f" before adding that autofocus element: https:/
tags: | added: opac |
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in evergreen: | |
milestone: | none → 3.3-beta1 |
Changed in evergreen: | |
assignee: | nobody → Galen Charlton (gmc) |
milestone: | 3.3-beta1 → 3.2.4 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
I created a branch to make autofocus a lot more conservation. It is called: user/sandbergja /lp1796225_ dont_autofocus_ searchbar_ on_non- search_ pages
Here's a link: http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ sandbergja/ lp1796225_ dont_autofocus_ searchbar_ on_non- search_ pages
And here are the testing notes from the commit message:
1) In the public catalog, visit the search results, record view, library details, basket, and password reset pages. Notice that the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages. Notice that the cursor no longer leaps to the search bar.
4) Visit the home page of the public catalog. Notice that the cursor still leaps to the search bar on this page only.