Holds view does not refresh when navigating through search results

[Michele Morgan]

Evergreen 3.2beta

When viewing Holds view on a list of search results in the web client, the list of holds does not refresh when using the previous/next navigation through the list of search results.

To reproduce the problem on a concerto database:

Search the catalog for 'harry'
Select first record and choose Holds View - one hold exists for pickup at BM1
Select Next to move to the next record in the search results
Note that the hold list still shows the hold list from the first title

This behavior does not occur on a community server running 3.1.4, when navigating through the search hit list in Holds View, the hold list refreshes to match the displayed title.

[Shula Link (slink-g)]

Confirmed in 3.0.2

[Andrea Neiman (aneiman)]

This should have been fixed back in 3.0-alpha on bug 1672421. I am not seeing this on 3.1.5 or on 3.2 beta (test server bugsquash.missourievergreen.org).

[Michele Morgan (mmorgan)]

Here's the commit for bug 1672421:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=00faa720a8dd94c781c50d508189d719f7f7f0d0

The single line change in Open-ILS/web/js/ui/default/staff/cat/catalog/app.js was removed in this commit:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=14af809466039334348ba38b8417fb462d57f55b

Not sure if it was accounted for elsewhere in the new code.

I observed the holds not refreshing on three systems, a MassLNC sandbox set up for squashing at mlnc1.noblenet.org, an inhouse test system that has been upgraded to 3.2beta1, and also a "master-ish" system Ben Shum kindly allowed me to test on.

[Andrea Neiman (aneiman)]

Thanks for the additional info, Michele. I'm not sure why I wasn't seeing it on Missouri's test environment, but I checked on a local "master-ish" and now I am seeing what you reported.

[Mike Rylander (mrylander)]

Here's a branch bringing back the hold refresh when paging between records:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1792188-record-holds-paging

[John Yorio (jyorio)]

Tested and worked for me. I consent to signing off on this patch with my name and email: John Yorio, <email address hidden>

[Galen Charlton (gmc)]

Pushed to master, rel_3_3, and rel_3_2. This doesn't affect 3.1.x as far as I can tell. Thanks, Mike and John!