Subject heading link includes non-exact matches

[Jeff Davis]

EG 3.1.4

Clicking on a subject heading in the OPAC should only return records using that subject heading. Currently it includes any records where the terms from the heading you clicked on appear somewhere in the subject fields, which is not the same thing.

To put it another way, clicking a subject heading performs the equivalent of a "Contains" subject search from the advanced search page. It should do a "Matches exactly" or "Starts with" search.

Example:
1. Retrieve record 78 (Mozart, Horn concertos).
2. Click the "Concertos (Horn)" subject heading.
3. Results include record 5 (Huntington student recital, Dec. 6, 1999), which does not have "Concertos (Horn)" as a subject heading. It does, however, have "Concertos (Piano) -- Excerpts" and "Horn and piano music".

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1790231-subject-heading-link-exact-match-search adds "contains=>'exact'" to the query params for subject heading links, forcing an exact-match search when a heading is clicked.

[Garry Collum (gcollum)]

I tested using Jeff's strategy and lots more musical terms in the test database. The patch works perfectly. The number of records associated with a subject heading in the facets from a top level search, seemed to coincide with the number of records that you pulled up from clicking on a subject link in a record.

The signed-off patch is at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1790231-subject-heading-link-exact-match-search-signoff

[Jane Sandberg (sandbergja)]

Thanks for this patch, Jeff, and for the testing, Garry. The only problem I see is with the genre heading links. Those are in a slightly different format (they're written as facets), which don't need and don't play well with contains=>'exact'. With your patch applied, clicking on any genre heading link returns 0 results. I'm adding the needsrepatch tag for this reason.

For your testing pleasure, by the way, here are the IDs of the 21 records in the concerto dataset that include genre headings:

 207
 208
 210
 211
 212
 215
 217
 221
 223
 224
 225
 227
 229
 230
 231
 243
 244
 245
 246
 247
 248

[Jeff Davis (jdavis-sitka)]

I've pushed two additional commits to working branch user/jeffdavis/lp1790231-subject-heading-link-exact-match-search. The first new commit accommodates genre and other facet-based subjects where we don't want exact match. The second new commmit applies the fix when display fields are not in use, e.g. when you access the record directly without search terms. All three commits should probably be squashed before merging to master.

[Kyle Huckins (khuckins)]

Thanks for this patch and the testing all, however this doesn't seem to be working as expected after rebasing to current master.

Genres work as expected, however with the initial example of record 78, clicking on "Concerto (Horn)" filters the list down to 2 items: Horn Concertos and Huntington Student Recital(noted to not have that subject heading). None of the subject headings under record 207 appear to work, as well. My best guess is that some change has been made to the API that will need to be addressed, though I'm not sure what that change would have been.