Cannot choose workstation on mobile

[Christopher Burton]

When trying to log into the staff web client on a mobile device, a dropdown for workstations shows even though no workstations have been assigned so it doesn't allow the creation of one either when trying to sign in.

This is occurring on 3.1.5 web client

[Kathy Lussier (klussier)]

Is this an iOS device? I just tested it on Android, but didn't see the problem.

[Christopher Burton (cburton)]

I have tested on every mobile browser I can think of. It works on my phone because I have a workstation saved in my cache but on any fresh browser (no cache) I can't sign in at all. BMagic confirmed with me he had the same issue as well

[Christopher Burton (cburton)]

Both android and iOS

[Kathy Lussier (klussier)]

I can confirm this bug on master and in 3.1.5. This worked as expected when I tested it yesterday on a 3.1.4 system.

Using an Android phone / Chrome browser that did not have a workstation stored in local storage, when I tried to access the web client login screen, I have a dropdown for the workstation selector, as Christopher described, with no workstations listed. The expectation is that no workstation selector appears here since we have no workstations set in local storage. It also immediately gives me a failed login message even though I have not yet attempted to log in. See the screenshot at http://www.screencast.com/t/XUPhwRGr

If I enter a user name and password, login fails, presumably because a workstation has not been selected.

The system I tested yesterday was running 3.1.4. I upgraded the system to 3.1.5. When I initially arrived at the login screen, my previously-configured workstation was available in the dropdown selector. After clearing local storage and the cache, I see the behavior described above.

[Bill Erickson (berick)]

It's the shared workers added to fix the IndexedDB issues (bug #1775719).

At least, I have confirmed a similar-looking issue in desktop Safari.

The JS console reports:

undefined is not an object (evaluating 'service.worker.port')

https://caniuse.com/#feat=sharedworkers
https://developer.mozilla.org/en-US/docs/Web/API/SharedWorker#Browser_compatibility

Not sure why Mozilla says it's supported in Chrome for Android, though.

[Bill Erickson (berick)]

The quickest fix would be to say we only support offline mode in Chrome and Firefox. With that we could add checks to avoid the login errors in Safari, etc.

BTW, I don't imagine shared web workers will be supported in Safari any time soon:

https://webkit.org/status/#feature-shared-web-workers

[Bill Erickson (berick)]

Correction: only support offline mode in *desktop* Chrome and Firefox.

[Bill Erickson (berick)]

Here's a branch that gets Safari working again:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1789747-shared-workers-check

In addition to sanity checks, it disables the Offline Circulation menu option when SharedWorkers are not available (i.e the offline UI won't work).

I am still having issues with Chrome for Android, but I don't have the tuits at the moment to set up remote debugging and determine the issue. Curious what others see.

[Christopher Burton (cburton)]

Still getting a couple errors with Safari after applying the fix.

[Log] egAuth found no valid authtoken (core.bundle.js, line 1)

[Debug] egStartup.expiredAuthHandler() (core.bundle.js, line 1)

[Error] SharedWorker() not supported – ReferenceError: Can't find variable: SharedWorker — core.bundle.js:1:56337
ReferenceError: Can't find variable: SharedWorker — core.bundle.js:1:56337

[Error] undefined is not an object (evaluating 'o.worker.port')
https://test.nflibrary.ca/js/ui/default/staff/build/js/core.bundle.js:1 – "<div ng-view=\"\" class=\"ng-scope\">"

[Bill Erickson (berick)]

Hi Christopher, the first 3 log entries are fine. The final message should no longer appear.

As part of my patch, the "SharedWorker() not supported" message was changed from an 'error' to a 'warn' in the log. This suggests to me the patch was not successfully applied/built or you need to force-clear your browser cache.

[Christopher Burton (cburton)]

Is there anything that requires a restart after applying it?
It wouldn't, right? Because it is all Javascript modifications.

I cleared my Safari cache and still having the errors so I am going to double check the patch application I did Friday on our test server and will re-update

[Bill Erickson (berick)]

No restarts are required, but you will have to "npm run build" in Open-ILS/web/js/ui/default/staff before reinstalling the files.

[Christopher Burton (cburton)]

Thanks to Berick, I have successfully applied the patch and resolved workstation selection.

Although, now Register Patrons is not loading in the same browsers that had the SharedWorker issue. Checked on Mobile Chrome, Safari (Both mobile and desktop)

This exists @ /eg/staff/circ/patron/register

Possibly unhandled rejection: undefined
vendor.bundle.js:2315

[Bill Erickson (berick)]

I've added some additional sanity checks to the offline caching code to resolve the patron register errors noted above.

Pushed to same branch, but the branch has been rebased to (a busy) master.

==

As an aside, I noticed while testing that expire dates are not parsing in Safari, leading to console errors, because it's implementation of Date.parse dislikes time zones like "-0400" -- it prefers "-04:00".

[Christopher Burton (cburton)]

Same error vendor.bundle.js:6:47851

function Tt(){
this.$get = ["$log", function(e) {

}

[Christopher Burton (cburton)]

Submitted that too early but this is the function still returning an error.
Same position as before but I think the error above is for the minified line

[Christopher Burton (cburton)]

I notice when building the bundle with npm though that offline-db-worker is returning 404

04 09 2018 16:19:53.723:WARN [web-server]: 404: /js/ui/default/staff/offline-db-worker.js

It exists in that location in Open-ILS/web/ but doesn't find it

[Bill Erickson (berick)]

Christopher, if your last comment is referring to 'npm run test' then then inability to load offline-db-worker.js is OK (and expected).

[Heather Lindskold (heatherlindskold)]

This is still affecting us in 3.1.5 on Chrome on iOS devices AND android devices. It does appear to work on Firefox on Android but requires a fresh install.

[Kathy Lussier (klussier)]

Bill - Should this bug have a pullrequest?

[Scott Thomas (scott-thomas-9)]

I tested Firefox on iOS, and the problem occurs.

[Bill Erickson (berick)]

I have added a pullrequest for my branch. Regardless of whether it fixes all the things, I think it's a good thing to have, because it performs various sanity checks which should have been added anyway. And when last tested, it allowed me to login to Safari, which I could not do before.

[Rogan Hamby (rogan-hamby)]

Worked for Safari for me as well, signoff at user/rogan/lp1789747_no_workstation_on_mobile

[Galen Charlton (gmc)]

I've pushed the branch to master, rel_3_2, and rel_3_1. I've also pushed a follow-up to ensure that the offline circulation menu item gets fully disabled (as otherwise, one could still click on it).