Autogen does not refresh unlocalized org tree cache

[Jeff Davis]

The org tree is stored in memcached separately for each locale: "orgtree.en-US", "orgtree.en-CA", etc. When the org tree is updated, running autogen deletes all the cached localized orgtree values, forcing them to be refreshed.

However, the orgtree is also stored in memcached in a non-localized form with "orgtree." as the cache key (e.g. when AppUtils->get_org_tree() is called without a locale param). This non-localized form does not get updated when autogen is run and therefore remains out-of-date.

We should be able to fix this problem by modifying the org_tree_js() function in OpenILS::Utils::Configure so that it removes "orgtree." from the cache along with the locale-specific orgtree values.

(Sitka ran into this issue after adding a new org unit. System-wide non-staff searches began failing with a query error: Can't call method "opac_visible" on an undefined value at /usr/local/share/perl/5.18.2/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm line 1177. QP grabs your search org's descendants from the database, then looks up each one in the cached non-localized orgtree -- but since autogen doesn't update the cached orgtree, looking up the new org unit produces an error. Manually removing the stale "orgtree." value from memcached worked, but is not a permanent solution.)

[Mike Rylander (mrylander)]

Here's a branch that does what Jeff suggests: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1786987-remove-no_locale-org-tree-cache

[Bill Erickson (berick)]

Issue and fix confirmed. Code pushed to 3.0 and up w/ slight modification to move 'my $cache' up a few lines for compilation happiness. Thanks Mike, Jeff.