Web Client: Reporter - External Documentation Links Do Not Work

Bug #1784893 reported by John Amundson on 2018-08-01
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned
3.2
Medium
Unassigned

Bug Description

Tested in Web Client 3.0.8 and 3.0.10
Observed in both Chrome and Firefox

If a report template includes an external documentation link, clicking the link does not work. Instead of opening the document, the Reports interface simply reloads. If opening the link in a new tab, another instance of the Report interface is opened in the new tab.

This happens on templates regardless of where they were created, (xul or web).

Changed in evergreen:
status: New → Confirmed
tags: added: reports
Changed in evergreen:
importance: Undecided → Medium
Terran McCanna (tmccanna) wrote :

I removed some logic relating to a xulG object that doesn't appear to be needed any longer. Is there any reason it should still be there?

My patch for testing is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1784893_reporter_doc_links

tags: added: pullrequest
John Amundson (jamundson) wrote :

I have tested this code and consent to signing off on it with my name, John Amundson and my email address, <email address hidden>.

The code was tested on a 3.2.3 system that has a XUL client built for it. External Documentation links worked in both versions of the staff client, (web and XUL).

Thank you for your work on this, Terran.

tags: added: signedoff
Changed in evergreen:
milestone: none → 3.3-beta1
Jason Stephenson (jstephenson) wrote :

Pushed to master, rel_3_2, and rel_3_1, for reporters everywhere!

Thanks, Terran and John!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers