web client: Local storage settings with Print Item Label interface

Bug #1783172 reported by Kathy Lussier on 2018-07-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

The Apply and Default buttons in the top bar of the Print Item Label interface perform actions that I wouldn't expect. Here is what I see:

If I apply a template from this interface, the following settings are added to local storage:

cat.printlabels.default_template
eg.print.template.item_label
eg.print.template_context.item_label
eg.print.template.item_label_cn
cat.printlabels.last_settings

While it might make sense for the Apply button to update cat.printlabels.last_settings, I don't think most users would expect it to also set the Default template. Every time you apply a new template when printing labels, you would be setting a new default, which defeats the purpose of having a default.

Initially, I thought the Default button would set the default template to whatever was selected in the dropdown menu. However, clicking the button seems to remove all of the local storage settings mentioned above with the exception of cat.printlabels.default_template. I'm not quite sure what the intended purpose of that button is.

Without further understanding the original intent of these buttons, I'm not sure if this is a bug or a UI issue, but I do think the following changes should be made:

1. Clicking Apply should not set the default template. There should be a separate action that explicitly sets a default template.
2. The Default button needs a verb or a totally new label. If it's meant to set the default template and just isn't working as expected, "Set Default" would work here. If it's meant to restore default settings (maybe to the YAOUS related to spine labels?), it should say "Restore Default."

Kathy Lussier (klussier) wrote :

Looking at the code, I see now that the Default button is supposed to Reset to Default, so it does seem appropriate to remove those local storage settings.

I'm still unsure of why the Apply button is setting a default template.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers