All grocery bills are styled like overdues in the Bills tab of the User editor

Bug #1782631 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.1
Fix Released
Medium
Unassigned

Bug Description

Eg 3.1.9, master as of 2018-07-19

Since the addition of bill coloring and status icons to the patron bills list, grocery bills have been styled the same as overdues, confusing staff. Adding a check for a due date to the mix clears that up. Branch inbound.

Tags: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

These bills are (less) stylin': http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1782631_bill_style working/user/jboyer/lp1782631_bill_style

To test, load a user with lost, overdue and still out, overdue and returned, long overdue, and grocery bills.

Pre-patch: All but overdue and returned will be styled. Lost, long overdue, and overdue as expected, but grocery will also be red with a clock icon.

Post-patch: Only the lost, long overdue, and overdue and still out will be styled; the overdue and returned and grocery lines will be plain.

tags: added: pullrequest
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Revision history for this message
Dan Wells (dbw2) wrote :

Works for me; pushed to master and rel_3_1. Thanks, Jason!

Changed in evergreen:
milestone: none → 3.2-beta
assignee: Dan Wells (dbw2) → nobody
importance: Undecided → Medium
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.