Web Client: Cannot Override Patron Message Block

Bug #1781641 reported by Joan Kranich on 2018-07-13
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
3.0
High
Unassigned
3.1
High
Unassigned

Bug Description

Evergreen release 3.0.8
Browsers: Chrome, Firefox

In the Web Client staff are not offered the option to override a patron block that is placed from Messages/Apply Penalty.

The screen warns of the block with an OK option which closes the dialog box and does not allow the attempted action such as checking out an item.

The XUL Client warns of the block and the dialog box has options for Force this action? No Yes.

The login's Permission Group does have STAFF_CHR.override permission.
I am logged in as the library that placed the block.

Steps used to add block.
In the patron record click Messages.
Click Apply Penalty.
Select Block.

Pictures attached.

If the patron has another penalty such as exceeds fine limit, the dialog box shows both penalties and the option to Force Action which then allows the action to proceed.

Joan Kranich (jkranich) wrote :
Garry Collum (gcollum) on 2018-07-16
Changed in evergreen:
status: New → Confirmed
Kathy Lussier (klussier) on 2018-08-29
Changed in evergreen:
importance: Undecided → High
tags: added: webstaffblocker
Jeff Davis (jdavis-sitka) wrote :

The egCirc service has a "checkout_overridable_events" attribute, which is a hardcoded list of events that can be overridden by staff during checkout (there is a similar list for renewals). This list does not include STAFF_CHR or any of the other staff-applied standing penalties. Adding them to the list seems to do the trick; working branch user/jeffdavis/lp1781641-override-staff-applied-penalties does just that:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=0ebac986

This needs more thorough testing than I've given it so far.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.2-beta
Joan Kranich (jkranich) wrote :

I have tested this code and consent to signing off on it with my name,
[Joan Kranich] and my email address, [<email address hidden>].

tags: signedoff

Galen Charlton (gmc) on 2018-09-05
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) on 2018-09-05
tags: added: signedoff
Galen Charlton (gmc) wrote :

Tested and pushed to master, rel_3_1, and rel_3_0. Thanks, Jeff and Joan!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
milestone: 3.2-beta → 3.2-rc
James Fournie (jfournie) wrote :

Should this have added the relevant permissions to the DB as well?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers