Web Client: Sometimes Unable to Change Primary Patron Barcode within "See All" Box

[John Amundson]

Evergreen 3.0.8

If a patron has multiple barcodes, all their barcodes can be seen from the Patron Edit screen by clicking the "See All" button.

In the See All box, a barcode can be marked "Primary" by moving the radio button. We are finding that the change in primary barcode is NOT respected if choosing a barcode that is HIGHER in the list than the current barcode.

This can be tested/confirmed on any patron account with multiple barcodes.

For example, let's say a patron has 4 barcodes. When clicking "See All", the box displays the barcodes:

Barcode A
Barcode B
Barcode C (Primary)
Barcode D

If I change the primary card from Barcode C to Barcode D and Apply Changes, the barcode box displays the new primary barcode, and clicking Save saves the change on the patron account.

If instead I change the primary card to Barcode B or Barcode A and Apply Changes, the barcode box is NOT updated, Returning to "See All" will show the primary button did NOT move from Barcode C, and clicking Save does not save the change.

Sometimes, (unsure why), when bringing up the See All box, the barcode order will be different than it was previously; for example, it might now show:

Barcode B
Barcode C (Primary)
Barcode A
Barcode D

In this example, I would be able to change the barcode to A or D but NOT to B.

The barcode itself does not seem to matter, only the order displayed. I've also tested with variations of Active and not Active, and that does not seem to make a difference either.

[Garry Collum (gcollum)]

I added 4 barcodes to a patron account using the Concerto data. When creating these barcodes my primary barcode always appeared at the bottom of the list so I was never able to test any of the barcodes below the primary one to see if I could make them primary.

I went into the XUL client and made one of the upper barcodes primary and then went back into the web client. I was able to confirm that any barcode above the primary barcode in the list cannot be changed to the primary barcode and saved. Any barcode below the primary barcode can be changed to primary and saved.

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1781235_set_primary_barcode branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1781235_set_primary_barcode

[John Amundson (jamundson)]

Thank you for the patch, Galen, and to Jason for installing the patch to test.

I have tested this code and consent to signing off on it with my name, John Amundson and my email address, <email address hidden>.

[Jason Stephenson (jstephenson)]

Pushed to master, rel_3_1 and rel_3_0!

Thanks, Galen, John, and Garry.