Copy note "Public Note" checkbox doesn't stay checked until saved

[Remington Steed]

In the web client, when creating or editing a copy note, the "Public Note" checkbox doesn't stay checked if you close and re-open the modal window.

But if you check the box, click "OK", then click "Save & Exit" on the copy editor, it will save the "Public Note" value.

[Meg Stroup (mstroup)]

Can confirm the behavior described in the description and also that the workaround will result in the note displaying.

[Remington Steed (rjs7)]

Also, when attempting to change a public note back to private (by unchecking "Public Note", clicking "OK", then clicking "Save & Exit"), the change doesn't save. I mention this in case it gives clues to the cause of the other problem. But if unrelated, it can become a separate bug report.

[Remington Steed (rjs7)]

Found the solution to both. Branch coming first thing tomorrow.

[Remington Steed (rjs7)]

Or actually, make that "first thing Thursday".

[Remington Steed (rjs7)]

Here's the branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1778571_copy_note_public_flag_fix

Steps for testing are in the commit message. Note that clearing the browser cache is required to fully test the fix.

[Michele Morgan (mmorgan)]

This fix works exactly as Remington describes based on the excellent testing notes included in the commit. My signoff branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9ca946f5e9b8cd225592a58648c63584edeefe8b

[Chris Sharp (chrissharp123)]

Pushed to master and rel_3_2. Thanks, Remington and Michele!