The 007 Physical Characteristics Wizard should list characters as well as descriptions in the dropdown menus

Bug #1776003 reported by Jane Sandberg
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

In the XUL client, the physical characteristics wizard dropdowns contained entries like this:

a: Map
c: Electronic Resource

In the web client, the dropdown entries look like this:

Map
Electronic Resource

Not including the actual character that they propose to add. It was helpful to see both pieces of information when using this tool.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
a. bellenir (abellenir) wrote :

if i understand correctly, this should be fixed by branch lp1776003-show-circ-as-type-code (http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1776003-show-circ-as-type-code)

it just shows the code alongside the description in the dropdown on the item attributes editor. please let me know if other locations need to be updated as well.

tags: added: pullrequest
Revision history for this message
Chris Sharp (chrissharp123) wrote :

I tested this and was not able to see a change in the 007 Physical Characteristics Wizard (search title -> MARC Edit -> right click on tags in grid and select "Add 007", click on the "link" icon to the right of the field), but I do see the codes in Circulate As Type in the item editor. Perhaps there was some confusion about where the change needed to happen?

Revision history for this message
a. bellenir (abellenir) wrote :

Chris, thank you for clarifying. i'm still learning my way around.

updated the lp1776003-show-circ-as-type-code branch (http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1776003-show-circ-as-type-code).

hopefully this is closer to what y'all had in mind.

Mark (markmg)
Changed in evergreen:
assignee: nobody → Mark (markmg)
Galen Charlton (gmc)
Changed in evergreen:
assignee: Mark (markmg) → Galen Charlton (gmc)
importance: Undecided → Wishlist
milestone: none → 3.4-beta1
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a signoff and a follow-up that makes the code display in _all_ drop-downs in the wizard:

working/user/gmcharlt/lp1776003_signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1776003_signoff

This patch also adds release notes.

tags: added: signedoff
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Meg Stroup (mstroup) wrote :

Further confirmation that original bug has been successfully addressed. Tested on MOBIUS 3.3.0 for bug squashing.

Screenshot attached, showing that the web client 007 physical characteristics wizard now reflects XUL appearance, e.g.:

a: Map
c: Electronic Resource

Jane Sandberg (sandbej)
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Revision history for this message
Jane Sandberg (sandbej) wrote :

This works well for me. Thanks to both of you! I've pushed this to master so it can be included in 3.4.

Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers