Web Client: Items Out - no colour to indicate that items are overdue

Bug #1775286 reported by Christine Burns on 2018-06-05
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.1
Low
Unassigned
3.2
Low
Unassigned
3.3
Low
Unassigned

Bug Description

EG3.1

Items Out - overdue items should be highlighted in red.

see related bug https://bugs.launchpad.net/evergreen/+bug/1635386

in xul client overdue items are highlighted in red on the items out interface.

Andrea Neiman (aneiman) on 2019-03-05
summary: - Web Client: Item Status - no colour to indicate that items are overdue
+ Web Client: Items Out - no colour to indicate that items are overdue
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Low
tags: added: usability webstaffclient
Kyle Huckins (khuckins) on 2019-05-23
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Kyle Huckins (khuckins) wrote :

Branch pushed here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1635386-items-out-overdue-colors

Overdue items, whether Cataloged or Non-cataloged, are now highlighted in red when overdue.

tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Bill Erickson (berick) wrote :

I have confirmed Kyle's branch works as expected for standard overdue items. However, the additional logic to handle non-cat items is unnecessary and potentially confusing, since overdue non-cat items are never displayed anyway. My preference is for that part of the patch to be removed for clarity / simplicity.

Kyle Huckins (khuckins) wrote :

I've amended my previous commit with the suggested changes

Kyle Huckins (khuckins) wrote :

I noticed a couple thinkos - one in the branch name(it was reflecting the related task regarding the bills interface), and the other in the last commit in lp1635386. The CSS was applying a contrasting color to unvisited links, but not visited ones. New, essentially the same plus a CSS fix, branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1775286-items-out-overdue-colors

Michele Morgan (mmorgan) on 2019-08-26
Changed in evergreen:
milestone: none → 3.3.4
Jennifer Pringle (jpringle-u) wrote :

Fix is working as expected, regular items and pre-cats both show in red when overdue and go back to white when renewed.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers