vandelay finish_rec_import_attempt authority error

[Josh Stompro]

EG 2.10.6 - but looks the same in master.

In the finish_rec_import_attempt function of vandelay.pm, there is a attempt to change a method from a bib update to an authority update, but the check is trying to see if $$args{type} equals 'auth'. But it doesn't look like $$args{type] is ever set previously in the code. Or at least when the import fails for a record the type isn't set.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm;hb=HEAD#l1360

I ran into an issue where my sequence for authority.record_entry.id was set incorrectly after our migration, so importing authority records was failing because of the duplicate key check.

I was seeing errors about 'update_vandelay_queued_bib_record' being sent a vqar instead of a vqbr.
'open-ils.cstore: update method for type vqbr was passed a vqar'

along with an error about the $$args{type} not being set.
open-ils.vandelay.auth_queue.import: Use of uninitialized value in string eq at /usr/local/share/perl/5.20.2/OpenILS/Application/Vandelay.pm line 1357

To test with a failed authority load, you can set your authority.record_entry_id_seq to a value that will result in a non unique value, and then try to import an authority record.

Josh