Improvements to Patron Acquisition Request

Bug #1774277 reported by Andrea Neiman on 2018-05-30
This bug affects 12 people
Affects Status Importance Assigned to Milestone

Bug Description

Equinox has been contracted by PaILS to rewrite the Patron Acquisitions Requests interface in AngularJS for the web client, as well as address several bugs associated with this interface (all of which will be marked duplicates of this new bug).

Bugs addressed include the following:

Bug 1269865 ACQ user request can result in double (or quadruple) holds placement
Bug 1733425 Patron Acquisition Request Pickup Library not editable under certain conditions
Bug 1234247 Request for Improvements to the Patron Requests User Interface
Bug 1733689 Error navigating from acq line items to patron requests
Bug 1733691 Patron acquisition request entry point missing from web staff patron display Other menu
Bug 1733696 Patron acquisition request status

Full functional specifications can be seen here:

This development is currently in partner testing and a branch will be available shortly following that.

Andrea Neiman (aneiman) on 2018-05-30
Changed in evergreen:
importance: Undecided → Wishlist
Terran McCanna (tmccanna) wrote :

AngularJS? Or Angular?

Andrea Neiman (aneiman) wrote :

We are shipping this with AngularJS since this development was contracted, spec'd, and 90% code-complete before the official community decision to migrate away from AngularJS. There is a possibility that it can be updated as part of the general conversion of Acquisitions to Angular, and I've made a note to explore this during the spec phase of that project.

Remington Steed (rjs7) wrote :

Does this work include updating the documentation?

Andrea Neiman (aneiman) wrote :

Yes, we will be including updated documentation for the new interfaces.

Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Jason Etheridge (phasefx) wrote :

collab/phasefx/acq_requests_rebased @ working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/acq_requests_rebased

The unsquashed and un-rebased original can be found at collab/phasefx/acq_requests

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
tags: added: pullrequest
Jason Etheridge (phasefx) wrote :

I'll come back with a test plan and actual code tests :)

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Jason Etheridge (phasefx) wrote :

Force pushed a branch with a live_t/ test that exercises a specific Acquisition workflow.

For manual testing, this can get you started (assuming Concerto test data):

Login to the web client with a BR1 Acquisitions user at a BR1 workstation.

Go to Acquisitions -> Patron Requests

Click "Create Request"

In the "User Barcode" field, enter: 99999303411

In the "Request Type" field, choose "Books"

In the "Title" field, enter: test

Click "Save" at the bottom

Select the new row

Go to Actions -> Add Request to Seletion List

In the field "Add to Selection List", enter: test

Click "Save Record"

Select the row again

Go to Actions -> View Selection List

In the "Estimated Price" field, enter: 1

Select the checkbox for the Line Item.

In the "Copies" field, enter: 1

In the "Owning Branch" field, choose "BR1"

In the "Copy Location" field, choose "Audio/Video (BR1)"

In the "Fund" field, chosoe "AD (2018)"

Click "Apply to Selected"

Scroll the screen back to the top

In the drop-down menu that displays "--Actions--", choose "Create Purchase Order"

In the "Ordering Agency" field, choose "BR1"

In the "Name (optional)" field, enter: test

In the "Provider" field, enter: BRODART

Click "Submit"

Click "Activate Order"

In the field "Or create a new queue", enter: test

Make sure the "Import Non-Matching Records" option is checked.

Click "Submit"

Scroll the screen to the top

In the Line Items area, click "requests"

You should be back at the Acquisition Patron Requests interface, but with the PO Line Item ID referenced where the Pickup Library menu used to be. The Request Status for the user request should show "Ordered, Hold Not Placed".

Select the row

Go to Actions -> Cancel Requests

In the "Cancel Reason" field, choose "Canceled: Fulfilled"

Click "Cancel Requests"

The row should no longer be visible.

Click "Show Canceled Requests"

The row should be visible.

tags: added: pullrequest
Jason Etheridge (phasefx) wrote :

"where the Pickup Library menu used to be"

should be

"where the Patron Home Library menu used to be"

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Andrea Neiman (aneiman) on 2018-08-20
Changed in evergreen:
milestone: none → 3.2-beta
Jane Sandberg (sandbej) on 2018-08-23
tags: added: needsreleasenote
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Jason Etheridge (phasefx) wrote :

Thanks Jane, I've added an extra commit to the branch with some release notes. Is there any general guidance for writing such other than trying to mimic what's there?

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
tags: removed: needsreleasenote
Jane Sandberg (sandbej) wrote :

Thanks for asking, Jason. There is some guidance for release note entries here:

Your release note looks good to me!

Andrea Neiman (aneiman) wrote :

Noting that this was tested by staff from PaILS and Evergreen Indiana as part of Equinox's internal testing period. Internal testing was completed with all identified bugs resolved prior to the community pull request.

Bill Erickson (berick) on 2018-09-04
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Stepped through a number of scenarios. Looks good. These are great additions. Thanks, All! Merged to master.

Changed in evergreen:
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers