Optionally use full library name in org unit selector

[Jeff Davis]

In the web client, the org unit selector displays the library shortname. We would like to be able to optinally display the full library name instead.

An org setting that lets you choose one or the other would be a minimal fix. A more ambitious fix would be to add a parameter to eg-org-selector so that you can choose between the short or long form in different places in the web client.

[Jeff Davis (jdavis-sitka)]

Compare bug 1772206, which would display the full library name as a tooltip when you hover over the shortname. I think we want both: tooltip when displaying shortname + option to display full name.

[Galen Charlton (gmc)]

Would a user setting be an option, possibly in place of an org setting? That would allow per-user customization.

Alternatively, would simply displaying "shortname: long name" across the board work?

[Michele Morgan (mmorgan)]

Just to clarify, are we talking specifically about the org unit selector that appears in the angular staff catalog? The display change from Name to Shortname with the angular catalog is a difficult adjustment for staff who spend a lot of time working with the catalog in the client.

There are many places in the web staff client that have always displayed the org unit selector by shortname. Examples are:

Patron Search
Patron record Home Library
Hold pickup location
Holds Shelf
Transit List
Holdings Editor
and Local and Server Admin pages, etc.

Changing the display across the board, with or without a setting could cause real estate issues on busy screens.

Should the ou selector in the angular staff catalog be addressed separately from other screens?

[Jeff Davis (jdavis-sitka)]

It's not just the staff catalog, although that's probably the most important example right now. The use of shortname instead of library name throughout the client has been a long-standing issue for my consortium.

I think a user setting would not be ideal for this -- we want to be able to show the library name by default, and having to add a setting for every staff person would be painful.

[Diane Disbro (ddisbro)]

My consortium would like the option to see the long name everywhere a short name is displayed.

[Radium Public Library (brhsp)]

Our library would also like to see the long name everywhere a short name is displayed. It's quite important to us when placing or sending interlibrary loans. Is there anywhere in Sitka that the shortnames can be cross referenced.

[Bill Erickson (berick)]

Here's a branch to address the org selectors:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1771636-org-select-combo-names

This specifically addresses the main Angular org unit selector and the the org unit family selector.

This variation displays full name followed by (shortname), but the ordering of the names could be easily changed to display shortname first, etc.

It introduces a new workstation setting which can be enabled / disabled under the Administration => Workstation page ("Library Selector Shows Combined Names?").

NOTE because of differences between how Angular and AngularJS cache workstation preferences, it may be necessary to log out and back in after changing this preference.

[John Amundson (jamundson)]

This seems to work well on all the Angular screens I tested (Catalog Search, Holdings Editor, View Holds tab, etc).

I could see some future screen-specific improvements like increasing the size of certain org unit selector boxes, but that's much outside the scope of this, and the patch appears to work well.

The wording "Library Selector Shows Combined Names?" is a little confusing. Perhaps "Include Full Library Names in Library Selector?" would be better?

In any case, I'm adding my sign off. Thanks, Bill!

I have tested this code and consent to signing off on it with my name, John Amundson, and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

+1 to John's suggestion of tweaking the wording a little bit.

I see the value of Jeff's point in #4, but in PINES our shortnames are actually more clearly described than our full names in many cases. The shortnames also don't change as frequently as full names do. I'd be happy moving forward with this as a workstation setting at first to see how people use it. If it did change to always showing the full name (without a setting) then I would prefer it to show the shortname followed by the fullname.

[Michele Morgan (mmorgan)]

Pushed to master, incorporating John's tweak to the wording.

Thanks Bill, John, and all who weighed in!

This fix resolves bug 1949110. Since 1949110 is tagged as a staffcatalogblocker, I would be in favor of backporting this to 3.9 and 3.8. Thoughts?

[Jennifer Pringle (jpringle-u)]

We've tested this fix on our 3.9 test server and plan to use it when we upgrade to 3.9 so I'm in support officially backporting it to 3.9 (and 3.8).

[Michele Morgan (mmorgan)]

Based on support for, and no strong objections to backporting, also pushed to rel_3_9 and rel_3_8.

[Jason Boyer (jboyer)]

I've pushed a couple followups to also rename the upgrade script on rel_3_8 and rel_3_9.