web staff client not compatible with AngularJS 1.7.0
Bug #1771397 reported by
Galen Charlton
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
As noted in bug 1771371, the web staff client stopped building successfully once Angular 1.7.0 became available. Pinning AngularJS to 1.6.x worked around the problem, but this bug is for fixing the breakage.
Evergreen 3.0+
tags: | added: angular |
tags: |
added: webstaffclient removed: angular |
tags: |
added: angular removed: webstaffclient |
To post a comment you must log in.
A cursory glance through https:/ /docs.angularjs .org/guide/ migration# migrating- from-1- 6-to-1- 7 didn't turn up any removed constructs that Evergreen appears to be using directly.
Error messages in the console include this:
jquery.min.js:2 Uncaught Error: [$injector: modulerr] Failed to instantiate module egHome due to: modulerr] Failed to instantiate module egCoreMod due to: modulerr] Failed to instantiate module ngToast due to: modulerr] Failed to instantiate module ngSanitize due to: /dev-galen2. equinoxinitiati ve.org/ js/ui/default/ staff/build/ js/vendor. bundle. js:28:111) /dev-galen2. equinoxinitiati ve.org/ js/ui/default/ staff/build/ js/vendor. bundle. js:28:3187) /dev-galen2. equinoxinitiati ve.org/ js/ui/default/ staff/build/ js/vendor. bundle. js:6:20272) /dev-galen2. equinoxinitiati ve.org/ js/ui/default/ staff/build/ js/vendor. bundle. js:6:18165)
Error: [$injector:
Error: [$injector:
Error: [$injector:
TypeError: u is not a function
at n (https:/
at new n (https:/
at Object.s [as instantiate] (https:/
at i (https:/
Upon inspection, the line in question in the vendor bundle is a copy of AngularJS 1.5.11, which is being brought in by ngToast. Per https:/ /github. com/tameraydin/ ngToast/ issues, ngToast appears to no longer be actively maintained; an issue requesting bumping up the version flag to allow AngularJS 1.6 has not been acted upon. I'll investigate this thread further.