Web client build problems

[Kathy Lussier]

Using a checkout of master from today, I am unable to build the web client.

When running npm run tests, we get a lot of failed tests - https://pastebin.com/CA5frnuf

If I ignore the tests and proceed with building the client, I get a blank screen when trying to retrieve the client login page. I see the following in the Console - https://pastebin.com/xr7dbL4y

Dyrcona reported that npm is pulling AngularJS 1.7.0 instead of 1.6.x.

I had no problems with 3.0.

[Kathy Lussier (klussier)]

Posting a branch with code from Ben Shum that worked for him. I won't add a pullrequest until I've had a chance to try it on my test system. http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1771371-pin-to-angular-js-1-6

[Jason Stephenson (jstephenson)]

Looks like this is happening because 1.7.0 was just released and ^1.6.7 is pulling in 1.7.0.

I've confirmed this issue on master and rel_3_1.

Rel_3_0 is not affected as it pins the AngularJS version at 1.5

I pushed a signed-off branch, with a follow-up commit to change all angular package versions in package.json to ~1.6.7 to user/dyrcona/lp1771371-pin-to-angular-js-1-6.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1771371-pin-to-angular-js-1-6

It works for me, but I'd feel better if someone else tests it before pushing it to master.

[Kathy Lussier (klussier)]

It works for me. I've signed off on Jason's commit and merged the branch to master and release 3.1.

There was also some discussion in IRC about possibly pinning the versions for other dependencies to prevent future problems, but we wanted more input from other developers. I think it's still worthwhile to have that conversations, but I wanted to get this fix in before tomorrow's maintenance release.

Thank you Jason and Ben!