export of records as marcxml does not provide file to downlaod

[Angela Kilsdonk]

Exporting MARCXML records in MARC Batch Import/Export>Export Records displays the records within the Evergreen client, instead of generating a file of records to download.

Tested in 3.0.5 web client and xul client and 2.12 xul client.

1. Go to Cataloging>MARC Batch Import/Export>Export Records.
2. Indicate the record(s) you want to export.
3. Select MARC XML as the Record Format.
4. Click Retrieve Records.

The records will display in the client interface. I expected Evergreen to generate and download a file of the record(s) in MARCXML format (which is what happens when you export records as MARC21).

[Jane Sandberg (sandbergja)]

Confirmed in 3.1.0.

[Mike Rylander (mrylander)]

In the olden days, some browsers didn't understand the "attachment" content disposition. They only understood "inline" but would let the user save a file if a filename was provided. However, in these modern days, relevant browsers all do the right thing and know about both flavors of content disposition, so we, too, must change with the times and support the letter of the standard.

This commit fixes downloading of MARCXML from the Exporter module.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1760223-download-exported-records

[Jane Sandberg (sandbergja)]

Thanks for the fast fix, Mike! I have tested this code and consent to signing off on it with my email address, <email address hidden>, and name, Jane Sandberg.

[Cesar V (cesardv)]

I've tested this as indicated above and the fix works as expected on webstaff using latest Chrome: I see the MARCXML download as a file, and not to the page as txt.

Here's a signoff branch with the current signoffs

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/miker_lp-1760223-download-exported-records_signoff

[Galen Charlton (gmc)]

Merged to master, rel_3_1, and rel_3_0. Thanks, Mike, Jane, and Cesar!