Provide setting for honoring patron preferred pickup lib for staff placed holds

[Kathy Lussier]

Evergreen version: master

This is a follow-up to bug 1699838, which is a follow-up to bug 1167541.

We would like a setting allowing sites to override the patron's preferred pickup library for default pickup lib for staff-placed hold.

As a result of bug 1699838, we have a choice between defaulting to the staff workstation library or the patron's home library for a staff-placed hold. However, this default only comes into play if the patron has not set a preferred pickup library.

Copying from the other bug as to the reasons for overriding the patron-selected default:

If a patron is calling or walking into a specific library to ask staff to place a hold on their behalf, in most cases, I think they would expect to pick up their hold at that same library. In many cases, they may not even remember that they had set a default. I'm sure there are cases where a patron is calling another library because their own library is closed, but I would think that's the minority of staff-placed holds for our libraries.

[Dan Briem (dbriem)]

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1759382_staff_placed_holds_default_to_ws_ou

This is a new org unit setting for always using the staff's workstation as the default pickup location for staff placed holds, even if the user has a preferred pickup location set in their account.

The setting applies on staff placed holds in the Angular and Traditional/Bootstrap catalog. This includes hold group holds.

If this helps when testing, this is the priority order for determining the default pickup location:

1. workstation if circ.staff_placed_holds_default_to_ws_ou
2. user preferred location if opac.default_pickup_location
3. workstation if circ.staff_placed_holds_fallback_to_ws_ou
4. user home org unit

When testing on 3.7+, you might need to watch out for bug 1939426. Basically, when placing holds in the Traditional/Bootstrap catalog as staff, you might want to make sure you've created at least one hold group so the interface appears (the JavaScript looks for something in the interface and errors out if it's not there), otherwise all of the user settings may not fill in when placing holds for individual patrons.

[Dan Briem (dbriem)]

I just realized I only pushed part of the branch. Will share new branch for testing soon.

[Dan Briem (dbriem)]

Here's a new branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1759382_staff_placed_holds_default_to_ws

This is a new org unit setting to always default the pickup location to the workstation when placing holds as staff, regardless of the patron's preferred pickup location.

The setting applies to staff placed holds in the Angular and traditional catalogs.

Priority for determining the default pickup location when placing holds as staff:

1. workstation if circ.staff_placed_holds_default_to_ws_ou
2. user preferred location if opac.default_pickup_location
3. workstation if circ.staff_placed_holds_fallback_to_ws_ou
4. user home org unit

Note: this doesn't apply to hold group holds. I realized that the existing circ.staff_placed_holds_fallback_to_ws_ou setting doesn't apply to hold groups, and that might be on purpose, so this setting doesn't either. I will create a new bug report to determine if the pickup settings should apply to hold groups.

[Ted Peterson (devted)]

Commit 621195743f57b2bff2d671652ff58503df9d608e had a conflict and
I included Dan's addition on the MOBIUS bugsquash server for file
950.data.seed-values.sql.

[Gina Monti (gmonti90)]

I, Gina Monti, sign off on this fix. The staff default library for pickup will override the patron's after applying org unit settings mentioned above.

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.8. Thanks, Dan and Gina!