Alternate hold pickup popup displays when checking out item to hold patron

Bug #1755502 reported by Kathy Lussier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

Evergreen version: 3.1

Evergreen 3.1 has code that generates a new popup when checking out items on the holds shelf to a patron who is not the holds patron. However, the popup also displays when checking out the hold to the holds patron.

This alert also appears to be the cause of failures for the 19-lp1306666-abort-transit-copy-status.t live test.

Revision history for this message
Kathy Lussier (klussier) wrote :

It suddenly occurred to me that this bug could have also been caused by the new copy alert work.

I did some additional testing to see if I could pinpoint the cause of the problem. After reverting the code that was added for the holds pickup work on bug 1661688, I found that the "Item On Hold Shelf" alert only displayed when checking out to somebody who is not the holds patron, as is the expected behavior.

Dan Pearl (dpearl)
Changed in evergreen:
assignee: nobody → Dan Pearl (dpearl)
Revision history for this message
Dan Wells (dbw2) wrote :

Untested, but a quick eyeball tells me we need to do this:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/dbwells/lp1755502_fix_hold_user_test

working/collab/dbwells/lp1755502_fix_hold_user_test

Revision history for this message
Dan Wells (dbw2) wrote :

A quick run, and 19-lp1306666-abort-transit-copy-status.t looks happy after the above change, at least.

Revision history for this message
Dan Pearl (dpearl) wrote :

I support Dan's change. To get access to the name of the owner of the hold, the hold was fleshed to another level, which made the reference to the structure's id incorrect.

Changed in evergreen:
assignee: Dan Pearl (dpearl) → nobody
Revision history for this message
Dan Pearl (dpearl) wrote :

I will test this today.

Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

The branch user/gmcharlt/lp1755502_signoff contains a signoff.

tags: added: pullrequest signedoff
Changed in evergreen:
status: New → Confirmed
assignee: Galen Charlton (gmc) → nobody
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Revision history for this message
Dan Wells (dbw2) wrote :

Thank you Galen for testing, and also for outlining the test steps. Pushed to master for inclusion in the 3.1 RC.

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.