Offline patron registration interface doesn't load

[Kathy Lussier]

Version: master

The offline patron registration interface no longer loads. When trying to retrieve the interface, regardless of whether I'm online or offline, I just see a progress bar.

This was originally reported in https://bugs.launchpad.net/evergreen/+bug/1751498/comments/7.

In comment #9 of bug 1751498, I reported on an error message I see in the Console. However, it turns out that this error arises when initially retrieving the offline interface, not when retrieving the patron registration interface. Nothing appears in the Console once I click the register patron tab.

[Jennifer Pringle (jpringle-u)]

I can confirm that the offline patron registration interface doesn't load in 3.1 RC

[Mike Rylander (mrylander)]

I am able to load the patron reg interface in offline mode, however, I was seeing the error messages in comment #9 of bug 1751498 as well. I've fixed that at branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1755220-offline-patron-reg-loading

I don't know if this will address all issues others are seeing in this area, but it did clear up more than one (and some repeated) JS console errors.

[Terran McCanna (tmccanna)]

We applied this patch to our 3.0.2 test server but I'm still seeing the "q" error that Kathy reported when I initially open the offline interface, and the patron registration form still isn't loading. Screenshot attached showing browser console.

[Mike Rylander (mrylander)]

Thank you for testing, Terran. The patch is based on master-ish, and offline has changed some since 3.0, so I wonder if there is some intervening fix for what you're seeing. To be clear, are you seeing less/different errors than before? I don't see the error you mention in the console output screenshot (the one there is just a warning about the browser not being able to de-compactify some JS).

Also, is this test after a hard refresh with the cache disabled via the dev tools?

Thanks!

[Terran McCanna (tmccanna)]

Yes, our 3.0.2 definitely doesn't have all the intervening patches applied to it so it could be another issue. Browser cache was cleared and pages refreshed - also tried in both Firefox and Chrome. We're seeing the same behavior as we were without this patch (the console wasn't giving us any helpful errors before either).

[Dawn Dale (ddale)]

The offline patron registration page now loads. This is working as expected.

[Dawn Dale (ddale)]

I have tested this code and consent to signing off on it with my name,
Dawn Dale and my email address, <email address hidden>

[Jason Stephenson (jstephenson)]

Mike's branch works for me on master and rel_3_0. It eliminates some nasty console errors and offline still works for checkin, checkout, and registering new patrons.

Pushed to master, rel_3_1, and rel_3_0.

Thanks, Mike, Dawn, Terran, Kathy, Jeanette, and Jennifer!