Wishlist: Patron Reg. Field Label Override

Bug #1754110 reported by Kyle Huckins
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

While working on a customization to the patron registration/edit interface, I found that the draw_field_label macro grabs a label by the idl field. I've added an additional parameter where a developer can add a string to override the idl field label to display different text as needed, and we thought it might be useful for other libraries as well. The branch is available in the comments.

Revision history for this message
Kyle Huckins (khuckins) wrote :
tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Kathy Lussier (klussier) wrote :

Kyle,

Could I have a test plan for this to give me some guidance on how to test it? We also probably need a release notes entry.

Thanks!
Kathy

tags: added: needsreleasenote
Revision history for this message
Kyle Huckins (khuckins) wrote :

Hey Kathy,

I'll write up a release note. It's a utility feature for devs to work with, so the test plan would look something like:

1. Create a new Patron Reg input field or pick an existing one.
2. Supply a string as a third parameter.
3. Save, Build
4. See that the input field's label matches the supplied string.

Revision history for this message
Kyle Huckins (khuckins) wrote :

I've updated the branch by rebasing to the latest master, and added release notes in an additional commit - I wasn't entirely certain where to place them, but the API subfolder seemed closest to what would make sense.

Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.next
tags: added: patron
Kyle Huckins (khuckins)
tags: removed: needsreleasenote
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Kyle. It works well for me. I was able to add all sorts of amusing labels to the fields in the patron registration form! :-D

Signoff branch at user/sandbergja/lp1754110-patron-reg-field-label-override-signoff

Changed in evergreen:
milestone: 3.next → 3.6-beta
tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master for inclusion in 3.6, along with a tweak to the release notes. Thanks, Kyle and Jane!

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.