webstaff holdings view: call numbers without copy can trigger exception

[Galen Charlton]

When displaying the Holdings View tab for a bib in the web staff client, if a volume record has no copies, a Javascript error gets thrown:

vendor.bundle.js:6 TypeError: Cannot read property 'length' of undefined
    at holdings.js:122
    at Object.o [as forEach] (vendor.bundle.js:6)
    at holdings.js:121
    at u (vendor.bundle.js:6)
    at vendor.bundle.js:6
    at h.$digest (vendor.bundle.js:6)
    at vendor.bundle.js:6
    at r (vendor.bundle.js:6)
    at vendor.bundle.js:6 "Possibly unhandled rejection: {}"

The offending line is this:

                // create virtual field for copy alert count
                angular.forEach(svc.copies, function (cp) {
                    cp.copy_alert_count = cp.copy_alerts.length;
                });

Item-less volumes still end up in svc.copies at this point, so at the moment it is necessary to check whether copy_alerts actually exists. Some renaming might also be in order to clarify that svc.copies doesn't necessarily contain /only/ fleshed acp records.

Evergreen master/3.1

[Mike Rylander (mrylander)]

This is addressed in the branch located at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/holdings-view-omnibus

[Dan Wells (dbw2)]

I have extracted this small fix from the omnibus branch and pushed it in, as I didn't see any dependencies with the rest of the branch. Also, this doesn't affect 3.0, so removed the target. Thanks, Galen and Mike!

I will also be rebasing the omni branch to account for this extraction.