Web Client: Apply Payment button on patron Bills screen should be inactive if Payment Received is blank

[Michele Morgan]

Evergreen 3.0.3

In the xul client patron bills screen, if no billings are selected OR no amount is entered in the "Payment Received" box, the "Apply Payment" button is not greyed out, but clicking it produces a pop-up message:

No payments or patron credit applied.

In the web client, the "Apply Payment" button appears greyed out if no billings are selected. With billings selected, the button is active whether or not an amount is entered in "Payment Received"

If "Apply Payment" is clicked without an amount entered, there is no pop up warning that no payment has been made. This could lead to payments not being credited to a patron's account.

For feature parity with the xul client, a pop-up warning is needed that no payment has been applied. But my preference would be for the "Apply Payment" button to remain inactive unless billings are selected and an amount is entered in "Payment Received"

[Garry Collum (gcollum)]

Attached is a patch that provides a solution based on Terran's second option. After applying the patch the Apply Payment button doesn't activate unless both a billing or billings are checked and a numerical value is entered into the Payment Received text box.

[Garry Collum (gcollum)]

Patch submitted to Evergreen working repository. http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=c9d9bf19f863a51cc5fee51ee5f737f46a2dccd1

[Cesar V (cesardv)]

This works fine, thanks Garry.

Here's a signed off branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/_gcollum-LP1749994-payment-button_SIGNOFF

[Dawn Dale (ddale)]

I have confirmed this is fixed. The payment button remains grayed out until a payment amount is entered.

[Dawn Dale (ddale)]

I have tested this code and consent to signing off on it with my name,
Dawn Dale and my email address, <email address hidden>

[Bill Erickson (berick)]

Added Dawn's sign-off. Did some minor commit message reformatting. Merged to master, 3.1, and 3.0. Thanks, all.