SMS Carrier not available as a column option in the web client

[Garry Collum]

Evergreen 3.0.2
Web Staff Client

SMS Carrier is not a column option of the column picker for the holds list when viewing the list in a patron's record.

[Garry Collum (gcollum)]

Proposed patch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1748265_sms_carrier_in_patron_holds_list

[Dawn Dale (ddale)]

I am testing this bug patch.

[Dawn Dale (ddale)]

I tested this and I still do not see the SMS carrier as an option in the dropdown list of the column picker on the holds screen in the patron account. Please let me know if I am not looking in the correct place.

[Terran McCanna (tmccanna)]

We may have been seeing a problem with our test server when we tested this, we will try again.

[Dawn Dale (ddale)]

I just found out the patch was not applied when I tested. I will test again.

[Dawn Dale (ddale)]

I have tested this code and consent to signing off on it with my name, Dawn Dale and my email address, <email address hidden>

[Bill Erickson (berick)]

Thanks Gary, Thanks Dawn.

I have pushed an additional branch to:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1748265-hold-list-sms-carrier

This branch includes mine and Dawn's sign-off on Gary's commit.

It also includes a commit to support the "include_sms_carrier" option to the holds API to add the server-side component matching Gary's changes. This means the data will be retrieved with the hold instead of requiring the grid make a batch of API calls after the fact, which would negatively impact render speed of the grid.

[Garry Collum (gcollum)]

I tested Bill's patch along with the changes that he made in my original patch and everything works perfectly. A signedoff branch of Bill's patch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1748265-hold-list-sms-carrier-signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Garry, Dawn, and Bill!