Circulation limit set test is not accounting for lost/longoverdue and paid items

Bug #1747542 reported by Chris Sharp on 2018-02-05
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.0
Undecided
Unassigned
3.1
Undecided
Unassigned
3.2
Undecided
Unassigned

Bug Description

Found in PINES production: When a patron tries to check out items that belong to a limit set (e.g. DVDs in our case), the action.item_user_circ_test() function checks to see if the patron already has the maximum number of items out within the limit set. If the patron has lost or longoverdue items and has paid for those items, the current check doesn't know about that and considers the circulation "active". Adding a check to see if the circulation is closed (action.circulation.xact_finish) fixes the problem.

Branch on the way.

Evergreen 3.0.2
OpenSRF 3.0.0
PostgreSQL 9.5
Ubuntu 16.04 LTS

Changed in evergreen:
milestone: 3.0.4 → 3.0.5
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.2-beta
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Jason Stephenson (jstephenson) wrote :

I'm really going to test it this time, I promise. :)

Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Jason Stephenson (jstephenson) wrote :

Looks like we're using LOST and not LONGOVERDUE, so there's no way for us to really test this.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
no longer affects: evergreen/3.1
Changed in evergreen:
milestone: 3.2-beta → 3.1.3
Changed in evergreen:
milestone: 3.1.3 → 3.1.4
Changed in evergreen:
milestone: 3.1.4 → 3.1.5
Changed in evergreen:
milestone: 3.1.5 → 3.1.6
Changed in evergreen:
milestone: 3.1.6 → 3.2.1
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
status: Confirmed → New
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers