Org Unit is not a hold pickup library still allows selection as Preferred pickup location

[Robert J Jackson]

webclient (OPAC) 3.0.3

When setting “OPAC: Org Unit is not a hold pickup library” is set to True for a given branch then the patrons can still select that branch as the Preferred pickup location.

When that setting is turned on patrons are not allowed to choose that location when actually placing a hold.

[Carrie Cleary (ccleary.pails)]

We used this setting to turn off holds for a location who is going through a short term no notice closing.
Patrons who had the location pre-existing as their preferred pickup location see that it looks ok, but then the hold simply doesn't go through. Desired behavior would be an error message Hold Not Placed library is not a pickup location. Perhaps with a suggestion to select another pickup location.

[Jessica Woolford (jwoolford)]

This is still an issue in 3.8.0, in both the staff client and the Bootstrap OPAC. In the Bootstrap OPAC, the hold fails silently as noted in comment #1. However, the hold succeeds when it is placed in the staff client.

[Susan Morrison (smorrison425)]

I think this can be marked Won't Fix since the preferred pickup location issues have been resolved through bugs https://bugs.launchpad.net/evergreen/+bug/1477154 (OPAC) and https://bugs.launchpad.net/evergreen/+bug/2000270 (staff client).