OPAC - Editing holds causes display issue in holds tab

Bug #1746815 reported by Mary Jinglewski
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned

Bug Description

This affects 3.0.0 through 3.0.3 of Evergreen. Behavior observed in both Chrome and Firefox.

When logged in as a patron in the OPAC, a display issue occurs, which restricts the listed holds in My Account > Holds to just one hold based on hold ID number. The workflow to cause this involves being in the holds tab of My Account (aka Holds display), editing the hold (via the Edit link), and when in the editing hold details screen, clicking on the holds tab (to return to the Holds display in theory). After that point, the Holds tab display will only show that hold when there is supposed to be a longer list of holds.

After this workflow occurs, the URL is also changed. e.g. [shortened URL]/eg/opac/myopac/holds?id=4468265

If you navigate away from this Holds screen in the My Account, the URL reflects the expected URL within the OPAC (including outside of the My Account area) but has the id number appended. e.g. /eg/opac/myopac/prefs?id=4468265

The only way to remove this singular hold view is to remove the ?id=##### from the URL manually.

Reported by Jason Goodson and confirmed by me, Mary Jinglewski.

Revision history for this message
Cesar V (cesardv) wrote :

Nice.

Revision history for this message
Cesar V (cesardv) wrote :
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
tags: added: pullrequest
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
status: New → Confirmed
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.0.4
Changed in evergreen:
milestone: 3.0.4 → 3.05
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Revision history for this message
John Amundson (jamundson) wrote :

We also had a library report this, and I was able to duplicate the issue using the steps outlined above by Mary.

We are on Evergreen 2.12.6. Tested in Chrome.

Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :

This works as advertised. While logged into the opac, clicking on Edit for a hold, then navigating away from the edit hold screen, the hold id is no longer retained on the url.

My signoff branch is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1746815_fix_myopac_hold_edit_urlparam_signoff

tags: added: signedoff
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_1, and rel_3_0. Thanks, Jason, Mary, Cesar, and Michele!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers