Circulation modifier typo (and inconsistency)

Bug #1746251 reported by Eva Cerninakova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.0
Fix Released
Undecided
Unassigned
3.1
Fix Released
Undecided
Unassigned

Bug Description

There is a typo in some templates: "Circulation Modifer" should be replaced by "Circulation Modifier"

The typo concerns two templates:

../../Open-ILLS/src/templates/staff/admin/serials/t_attar_edit.tt2:161
corrected code on line 161:
                      <b>[% l('Circulation Modifier') %]</b>

../../Open-ILLS/src/templates/staff/cat/volcopy/t_attar_edit.tt2:212
corrected code on line 212:
                     <b>[% l('Circulation Modifier') %]</b>

Except the typo there is also some inconsistently in using the term "circulation modifier". There are three variants:
Circ modifier
Circulation Modifier
Circulation modifier
(I wonder, whether this could also affect translation application in web staff client in some cases, see the bug 1719375)

"Circ modifier" is located in:
../../Open-ILLS/src/templates/acq/common/li_table.tt2:236
../../Open-ILLS/src/templates/acq/common/li_table.tt2:336
../../Open-ILLS/src/templates/acq/common/li_table.tt2:363
../../Open-ILLS/src/templates/acq/common/li_table.tt2:414
../../Open-ILLS/src/templates/acq/common/li_table.tt2:85
../../Open-ILLS/src/templates/acq/invoice/receive.tt2:44
../../Open-ILLS/src/templates/conify/global/acq/distribution_formula.tt2:54
../../Open-ILLS/src/templates/conify/global/acq/provider.tt2:154
../../Open-ILLS/src/templates/conify/global/config/circ_limit_set.tt2:28
../../Open-ILLS/src/templates/conify/global/config/circ_modifier.tt2:23
../../Open-ILLS/src/templates/staff/admin/serials/t_template_list.tt2:43
../../Open-ILLS/src/templates/staff/cat/item/t_summary_pane.tt2:166
../../Open-ILLS/src/templates/staff/cat/volcopy/t_edit.tt2:164
staff.browse_list.circ_modifier
staff.serial.batch_receive.circ_modifier
staff.circ.alternate_copy_summary.Circ_Modifier.label
field.aoupa.circ_mod.label:5835
field.act.circ_modifier.label:7268
field.acqlid.circ_modifier.label:9221
field.rccc.circ_modifier.label:11428
field.rocit.circ_modifier.label:11780

"Circualtion Modifier" is located in:
../../Open-ILLS/src/templates/conify/global/acq/provider.tt2:192
../../Open-ILLS/src/templates/conify/global/config/circ_modifier.tt2:2
../../Open-ILLS/src/templates/conify/global/config/circ_modifier.tt2:21
../../Open-ILLS/src/templates/staff/cat/catalog/t_holdings.tt2:114
../../Open-ILLS/src/templates/staff/cat/item/t_list.tt2:96
../../Open-ILLS/src/templates/staff/cat/volcopy/t_defaults.tt2:199
../../Open-ILLS/src/templates/staff/circ/checkin/t_checkin_table.tt2:102
../../Open-ILLS/src/templates/staff/circ/patron/t_bills_list.tt2:82
../../Open-ILLS/src/templates/staff/circ/patron/t_checkout.tt2:138
../../Open-ILLS/src/templates/staff/circ/patron/t_holds_list.tt2:56
../../Open-ILLS/src/templates/staff/circ/share/t_precat_dialog.tt2:30
 ../../Open-ILLS/src/templates/opac/parts/record/copy_table.tt2:48
staff.acp_label_circ_modifier
staff.cat.copy_editor.field.circulation_modifier.label
field.vii.circ_modifier.label:383
field.viiad.circ_modifier.label:435
class.ccm.label:1583
field.chmw.circ_modifier.label:1772
field.ccmw.circ_modifier.label:1802
field.chmm.circ_modifier.label:1860
field.ccmm.circ_modifier.label:1911
field.cclscmm.circ_mod.label:2033
field.sunit.circ_modifier.label:5458
field.acp.circ_modifier.label:7162
field.acqdfe.circ_modifier.label:9830
950.data.seed-values.sql:16281

"Circulation modifier" is located in:
../../Open-ILLS/src/templates/staff/serials/t_batch_receive.tt2:54
950.data.seed-values.sql:2772
950.data.seed-values.sql:2775

Revision history for this message
Eva Cerninakova (ece) wrote :

The typo still remains in 3.2 sandboxes

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I pushed a branch to fix the typos http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1746251-circulation-modifier-typo

It does not address the use of "Circ Modifier" versus "Circulation Modifier." That's an open discussion and a choice of one over the other may necessitate the adjustment of some interfaces to accommodate a longer or short string.

Changed in evergreen:
status: New → Confirmed
milestone: none → 3.2-rc
tags: added: i18n pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Looks logical to me. Pushed to master and backported to rel_3_1 and rel_3_0. The i18n templates will get fixed the next time we run PO template and PO sync during release time.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.