deprecate legacy in favor of new one

Bug #1745610 reported by Chris Sharp on 2018-01-26
This bug affects 4 people
Affects Status Importance Assigned to Milestone

Bug Description

Bug 1596595 introduced a hold targeting process that is faster, more efficient, and integrates better into OpenSRF than the "traditional" script. Since PINES and others have been successfully running the new targeter in production environments for over a year, I propose that we deprecate the old version in favor of the "v2" version.

Branch on the way.

Bill Erickson (berick) on 2018-01-26
Changed in evergreen:
status: New → Confirmed
Dan Wells (dbw2) wrote :

Bumped this up to "Low"; IMO, it can go in any time before release.

Changed in evergreen:
importance: Wishlist → Low
Changed in evergreen:
milestone: 3.1-beta → 3.1-rc
Changed in evergreen:
milestone: 3.1-rc → 3.1.1
Changed in evergreen:
milestone: 3.1.1 → 3.1.2
Changed in evergreen:
milestone: 3.1.2 → 3.1.3
Changed in evergreen:
milestone: 3.1.3 → 3.1.4
Changed in evergreen:
milestone: 3.1.4 → 3.1.5
Bill Erickson (berick) wrote :

Chris, mind applying the file name changes to Open-ILS/src/ (core_scripts = ...) and adding a release notes entry explaining that users may need to change their local crontab's to ensure it's running the script they think it's running w/ the correct params?

Changed in evergreen:
milestone: 3.1.5 → 3.1.6
Jeff Davis (jdavis-sitka) wrote :

I've retargeted this bug to 3.2-beta. Deprecating functionality doesn't really seem like a point-release kind of change, and the bug is more likely to get attention this way anyway.

Changed in evergreen:
milestone: 3.1.6 → 3.2-beta
Changed in evergreen:
milestone: 3.2-beta → 3.2-rc
Chris Sharp (chrissharp123) wrote :

Okay, finally saw Bill's request and I've made the requested changes, rebased, and force-pushed to the same location:;a=shortlog;h=refs/heads/user/csharp/lp1745610_promote_new_hold_targeter_to_default

Bill Erickson (berick) on 2018-09-14
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Thanks, Chris. Confirmed installer works as expected. Merged to master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers