Web Client: Hold Alias missing from Hold Shelf Slip

Bug #1745240 reported by Terran McCanna
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.0
Fix Released
Undecided
Unassigned

Bug Description

In 3.0.2:

The patron's hold alias field isn't available to the Hold Shelf Slip print template.

Revision history for this message
Garry Collum (gcollum) wrote :

I tested by adding the line <div ng-if="patron.alias">Alias: {{patron.alias}}</div> into the template and saving locally.

The patron.alias does now print on the slip. It also appears in the preview pane.

I created a small patch that adds 'patron alias' as one of the variable options in the description at the top of the template. It also adds a colon after 'Hold for patron' for consistency with the other rows in the template.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1745240_alias_on_hold_slip

tags: added: pullrequest
Changed in evergreen:
status: New → Confirmed
milestone: none → 3.2-beta
assignee: nobody → Jason Stephenson (jstephenson)
Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Revision history for this message
John Amundson (jamundson) wrote :

I have tested this code and consent to signing off on it with my name, John Amundson and my email address, <email address hidden>.

Thank you, Terran, Gary, and Jason!

tags: added: signedoff
removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Pushed Garry's branch to master, rel_3_1, and rel_3_0.

Thanks, Terran, John, and Garry!

Changed in evergreen:
status: Confirmed → Fix Committed
no longer affects: evergreen/3.1
Changed in evergreen:
milestone: 3.2-beta → 3.1.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.