copy_tag() search filter should not be orthogonal to site()

Bug #1745207 reported by Galen Charlton on 2018-01-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned

Bug Description

Currently, the copy_tag() search filter (used to implement the "Digital Bookplate" search) is orthogonal to the site() filter. This turns out to not reflect the typical bookplate search use case.

In particular, consider two systems, A and B, that share bib records but assign separate sets of digital bookplates. For example, suppose A assigns "Donated by Alice Smith" bookplates and B assigns "Donated by Beatrice Smith" bookplates to some of their respective items.

In such a situation, the following search

  copy_tag(bookplate, Smith) site(A)

will turn up up all records that have copies visible in A's scope and /any/ bookplate copy tags that contain Smith. However, this means that some of the results in the hit list may includes items at A that have /no/ copy tags, but are included because they have matching copy tags at B. This is not ideal, particularly in the case where a donor is searching for their own donations by bookplate.

Evergreen 3.0.3

Galen Charlton (gmc) wrote :

A fix is available at the tip of the user/gmcharlt/lp1745207_fix_copy_tag_search_scoping branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1745207_fix_copy_tag_search_scoping

tags: added: copytags search
tags: added: pullrequest
Changed in evergreen:
milestone: 3.0.4 → 3.05
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.0.9
Garry Collum (gcollum) wrote :

Tested. Works perfectly. Only records with a copy tag of the filtered location or the location's upward hierarchy appear in the results.

Signed off at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1745207_fix_copy_tag_search_scoping-signoff

tags: added: signedoff
Changed in evergreen:
milestone: 3.0.9 → 3.0.10
Chris Sharp (chrissharp123) wrote :

Pushed to master, rel_3_0 and rel_3_1. Thanks, Galen and Garry!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers