Fine level and loan duration aren't displayed when editing items

[Jason Boyer]

Eg 3.X

In the web client item editor the loan duration and fine level fields are hard coded as select tags so that we can manually map the numbers to translatable strings. While this appears to work when initially creating an item or applying a template (provided these numbers are stored as strings in the template...) these fields don't display their current values when editing an existing item. This obviously leads to staff confusion and questioning whether the values were set correctly initially.

[Jason Boyer (jboyer)]

The simple fix for this is to add a new directive to the ui service to convert the model from a number to a string. Since this kind of thing has come up in previous bugs (bug 1713064 and bug 1714390, which conflicted with bug 1712646 because a similar but not identical fix is required) I plan to address it by adding 2 pairs of symmetric directives to the shared egUiMod module; str-to-int and int-to-str, and str-to-float and float-to-str. Additionally the current uses of string-to-number in staff/cat/volcopy/app.js will be converted to the appropriate shared directive and the old string-to-number will be removed.

[Jason Boyer (jboyer)]

Here's the fix: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1741072-str-num-directives The existing stringToNumber directive is dumped and replaced with 4 directives attached to egUIMod so they can be used everywhere: strToInt and strToFloat, along with the reverse; intToStr and floatToStr. intToStr is necessary to correct this issue, strToFloat corrects issues with price, cost, and deposit, and strToInt will be used to fix bug 1712646. floatToStr is currently unused but included just in case.

[Bill Erickson (berick)]

Issue and fixes confirmed. Merged to rel_3_0 and master. Thanks, Jason.

[Bill Erickson (berick)]

Patch results in JS unit test failure:

 ✗ itemSvc.convert_xul_templates converts copy templates as expected

[Jason Boyer (jboyer)]

Oh, that would be because I didn't realize a test had been written for that. It's supposed to change also, the reason it was forcing those two fields to be strings was that doing so allowed them to be applied by copy templates. That didn't address the actual issue (select values are always considered strings, even ones matching ^[0-9]*$. With the change to those fields there's no need to special case those two in the conversion process. (with the added benefit that string-ified versions of templates still work with the corrected fields.)

[Jason Boyer (jboyer)]

What I thought would be a simple test alteration turned into me chasing down the fact that I removed way too much when throwing away the number -> string conversions. The above branch has been force-pushed with an update that alters the test and repairs the conversion function.

[Bill Erickson (berick)]

Sign off for Jason's unit test fixes pushed. Branch includes a second commit for replacing "string-to-number" with "str-to-float" on the copy deposit amount field.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1741072-str-num-directives-continued

[Galen Charlton (gmc)]

Tested and pushed to master and rel_3_0. Thanks, Jason and Bill!