Paging causes duplicate entries on the Web staff Patrons items out and Holds screens

Bug #1739648 reported by Dale Rigney on 2017-12-21
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.0
Undecided
Unassigned

Bug Description

Tested on version 3.0.2.

When viewing the Items out tab or Holds tab in the patron screen the listed records will be duplicated if you page past the last screen.

How to duplicate issue:

Search for patron in the web client that has a few checked out items
Click on the Items Out tab
You will the items out listed (note the Circ id of the first few items out)
click on the Nest Page icon (even if the icon looks like it is disabled)
You should see the note "No items To Display"
Click on the Previous page icon if you had 3 items checked out you will now see 6 items on the list.
Items 4-6 are duplicate entries of circulations 1-3.

The Holds tab does the same if you page click on the Next Page icon when the icon is disabled.

Scott Thomas (scott-thomas-9) wrote :

The duplicates also appear in the file if you opt to Download Full CSV.

Cesar V (cesardv) on 2018-01-05
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
Cesar V (cesardv) wrote :

The following branch should address the duplication issues, while also tackling the fact that the grid's "next" button wasn't disabling when there's more more data to page thru. It was missing grid.totalCount being wired and set (when possible).

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1739648_grid_paging_caused_dupss

Cesar V (cesardv) on 2018-01-09
tags: added: pullrequest webstaffclient
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Jason Etheridge (phasefx) wrote :

Looks good to me, but I'd still like another set of eyes from someone familiar with egGrid internals. Signoff branch here:

collab/phasefx/lp1739648_grid_paging_caused_dupss @ working

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1739648_grid_paging_caused_dupss

Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Jason Etheridge (phasefx) wrote :

I think we could open another bug for disabling the Jump to Specific Page actions.

Mike Rylander (mrylander) wrote :

Requests eyes applied, and they liked what they saw. Picked into master and rel_3_0. Thanks, Cesar and Jason.

Changed in evergreen:
status: New → Fix Committed
Mike Rylander (mrylander) wrote :

Requested, even...

Changed in evergreen:
milestone: none → 3.1-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers