Download Progress Bar Doesn't Close in Firefox

[John Yorio]

Steps to reproduce:

In Firefox log into the web client for Evergreen 3.0.2

Search for Copies by Barcode
Search for a valid barcode.
Download Full CSV

A green progress bar appears near the top of the screen.

The file downloads (I checked in the download directory) but the progress bar sits there.

Clear the progress bar by clicking on the screen.

If you clear the progress bar and then click Download Full CSV again, the progress bar does not appear. But now you've downloaded the file twice.

If you reload the Search for Copies by Barcode screen, the progress bar will appear again when you try to download.

I was unable to reproduce this in Chrome.

Ideally the progress bar would close automatically.

[Galen Charlton (gmc)]

Confirming that this is still an issue in main. This appears to affect all AngularJS egGrids, not just the 'Search Items by Barcode' interface.

Noting for anybody tracing this that the value of the browser.download.alwaysOpenPanel Firefox setting doesn't make a difference.

[Dan Briem (dbriem)]

Branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1739638_angjs_progress_bar_stays_visible

When printing or downloading an AngularJS grid, it seems like sometimes the data resolves before the dialog opens. Since the close logic runs when the data resolves, if the dialog opens after it remains open.

It seemed to happen more consistently after refreshing the page for some reason and this didn't seem to be limited to Firefox.

[Steven Mayo (stmayo)]

Looks pretty good to me! The loading bar did not open at all during a fast download as desired.
The downloads were finishing before the loading bar opened so often for me I had to download the entire set of concerto patrons to still the old loading bar. But it is still there.
Thanks Dan!

Signed off branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/smayo/lp1739638_angjs_progress_bar_stays_visible-signoff

[Galen Charlton (gmc)]

Pushed down to rel_3_11. Thanks, Dan and Steven!