Web client: deleted items in item status file silently fail

[Elaine Hardy]

When loading a file containing deleted items, the deleted items silently "fail" and no notification is given. If the entire file is deleted items, nothing happens - no notification and nothing loads into item status. In the XUL client, a click through box and warning sound occurs informing that the item is deleted. While this can be annoying if there are a number of deleted items in the list,it does let you know why an item has not displayed in the list and gives you the opportunity to resolve any issues around the item.

[Elaine Hardy (ehardy)]

Not sure if this is should be a separate bug or not. If the file of barcodes has a space after a barcode, the web client reads the space as part of the number and does not return it, it fails as if it were not present. The XUL client ignores the space and loads the file.

[Elaine Hardy (ehardy)]

If the file has a space before the barcode, the barcodes will also fail to load. However, if you manually enter a barcode with a space either before or after, it does scan as expected.

[Beth Willis (willis-a)]

Elaine noted that if all items in the file have been deleted, nothing happens when the file is loaded to the item status screen. I find that even if my file contains some undeleted items, along with some that have been deleted, nothing happens. The file never loads and the progress bar never goes away.

EG 3.1.8 and 3.2.4

[Elaine Hardy (ehardy)]

We are also seeing files stop loading when it encounters a deleted item. THe file might have several hundred items but if the deleted item is 10th from the bottom (the file loads from the bottom), only 9 items load.

[Jane Sandberg (sandbergja)]

Here's a branch that does this: user/sandbergja/lp1739288_report_invalid_barcodes_in_item_status

And here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1739288_report_invalid_barcodes_in_item_status

Note that, like the XUL behavior, this code does not differentiate between deleted items and barcodes that are totally mistyped and never were in the database.

[Jane Sandberg (sandbergja)]

For your viewing pleasure, here's a gif of my proposed solution.

[Elaine Hardy (ehardy)]

Love it!!

[Josh Stompro (u-launchpad-stompro-org)]

Jane, I like your solution to this issue, I marked a couple other bugs as being duplicates of this one. I like how you show them as they come up and not as a popup at the end.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

I just tested this out and it works great. The only thing that may be nice would to be to have a final summary of the load in the case that there are bad barcodes.

Something like:
"Summary: X not found or deleted barcodes, x found barcodes out of x barcodes in file."

That would make it faster to yell across the office, "Hey, that file of barcodes you sent me has 30 bad ones out of 40 in it, where did you get that anyway?"

But I would be fine signing off on it as it is now. I like how even a large number of bad barcodes is easily handled, and it is easy to copy and paste the output since it is just a list of the barcodes.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Here is a branch that adds a summary to the end of the bad barcodes list.

user/stompro/lp1739288_report_invalid_barcodes_in_item_status

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1739288_report_invalid_barcodes_in_item_status

Jane, I wasn't quite sure how to handle the string for the summary in a way that was I8N friendly. Does it hurt to have the {{}} interpolation inside the string that needs to be translated like that?

Thanks
Josh

[Jane Sandberg (sandbergja)]

Thanks for this, Josh!

I added your signoff and a commit similar to yours to this branch: user/sandbergja/lp1739288_report_invalid_barcodes_in_item_status

It uses a few of the variables that are already there, and only shows the summary after the dust has settled and the file is done processing.

[Josh Stompro (u-launchpad-stompro-org)]

Jane, this looks good and works well for me.

Here is my signoff branch, I've squashed the two commits.
user/stompro/lp1739288_report_invalid_barcodes_in_item_status_signoff
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1739288_report_invalid_barcodes_in_item_status_signoff

My one last question is if the summary should show even when no bad barcodes are in the file? Currently the counts are only shown if at least one bad barcode is detected.

It may be nice to have the count there as a nice confirmation that the file loaded with no issues.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

I added a screen shot of the list of bad barcodes and summary.

[Rogan Hamby (rogan-hamby)]

Sign off pushed to user/rogan/lp1739288_report_invalid_barcodes_in_item_status_signoff

[Galen Charlton (gmc)]

Pushed all the way to rel_3_4. Thanks, Jane, Josh, and Rogan!

I could see a couple of ways of going regarding Josh's comment #12:

- display the summary as is, but that adds a persistent confirmation message that the user may want to be able to dismiss
- throw up a toast

I didn't write a follow-up for either case, so I'll leave that up for anybody who is interested to open a separate bug.