Comment 11 for bug 1739087

Revision history for this message
Cesar V (cesardv) wrote :

Thanks for re-testing this Jason!
Right, so since that numeric input allows any sort of input, i.e users can enter zero or any negative values, yet those values don't have any effect and are "validated" by the constraints in place... I think entering 0 there manually should become a moot point, esp. since the new "X" button is tab-able and allows for better control of which volumes to delete. But then again I'm not a cataloger so that's just my two cents :)

Anyhow, I've added an aria-label="Delete" attribute to the X button that will permit accessibility devices to distinguish the delete button's function. Regarding the inline CSS... well I figured since the egVolRow directive has an inline template, I might was well just inline that small bit of CSS as well so that if/when these get rewritten/refactored into a proper/separate TT files, then the proper CSS rules are put in on it's own separate file too. I confess I do get a bit lost when trying to find the proper CSS file for a particular rule, but I am not opposed to creating a CSS rule for it however, since that's usually the way to go most times.