web client: holdings view checkboxes issues

[Kathy Lussier]

Evergreen version: all supported

I've found a few issues related to the checkboxes that appear near the top of the record Holdings View interface: Show empty volumes, Show copy details, and Show volume details.

In my testing, I've found the following issues.

1. If I have "Show empty volumes" selected, deselecting the "Show volume details" will not work. If I then deselect "Show copy details", this will not work either. Deselecting the "Show copy details" option is not a problem if it's the first checkbox I deselect. It only becomes a problem if I previously deselected the volume details option. The interface should either allow the 'show volume details' option to work no matter what the state of the 'show empty volumes' option, but, if that's not possible, this option should be disabled as long as the 'show empty volumes' option is selected.

I see the following in the console when I follow the steps in #1:

angular.js:14199 TypeError: Cannot read property 'concat' of undefined
    at holdings.js:207
    at Object.q [as forEach] (angular.js:325)
    at holdings.js:190
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

2. If I have "Show empty volumes" and "Show volume details" deselected, then pull up a new record and switch to Holdings View, I don't see details for all of the org units that should be displaying. See the screencast at https://drive.google.com/file/d/14WmqhYs-YTTHHk6lqO_GINGL1PQC_UmG/view.

3. In cases where "Show empty volumes" is deselected, deselecting the "Show volume details" will also remove copy details from the display. If you then toggle the copy details option, not changes are made to the interface. I'm not sure what the best solution is here, but, once the "Show volumes details" option is deselected, it might be good to disable the copy details option since its use will not result in any changes to the interface at that time.

[Mike Rylander (mrylander)]

All three of these have been addressed in the branch located at: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/holdings-view-omnibus

[Elaine Hardy (ehardy)]

If I followed Kathy's steps correctly, the check boxes appear to work.

[Tina Ji (tji)]

It appears to me to show copies details, you have to select to show volume details. Turning off Show Volume will make copy details disappear.

Starting from the state that both Show Vol and Show Copy are deselected, the first time you click Show Copy, the screen flashes, but the checkbox remains deselected. At this point, clicking Show Volume displays both vol and copy details, and makes Show Copy box selected. But if you click Show Copy one more time, instead of clicking Show Volume, the checkbox appears to be selected, but the copy details is not shown. Clicking Show Volume will display both Vol and Copy details.

Starting from both Show Vol and Show Copy are selected, deselecting Show Vol makes both copy and vol details disappear.

In another word, it is not possible to display copy details without showing vol details. I think this makes sense.

[Tina Ji (tji)]

BTW, the above behaviour is observed on this server: https://dev-bugsquash.equinoxinitiative.org/eg/staff/home

[Dan Wells (dbw2)]

Moving discussion to an omnibus bug for the omnibus branch...

Please see bug #1773417.