Acq: Funding Sources need an active flag

Bug #1737019 reported by Jason Boyer
40
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Eg 3.0

Currently funding sources are forever once credit has been applied. Depending on how granular you use them, you may tire of seeing the "Early Literacy Grant" source from a grant that was spent out 4 years ago. If funding sources could be de-activated that would prevent the list of funding sources from growing forever in ui lists. The manage funding source interface would still list them all in case you want to bring one back.

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Tiffany Little (tslittle)
Revision history for this message
Tiffany Little (tslittle) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Tiffany Little (tslittle) → nobody
Revision history for this message
Lindsay Stratton (lstratton) wrote :

Tested this in https://tiffany-master.gapines.org/eg/staff - works as advertised.

1 - edit to de-activate a fund source successful
2 - appears in default fund source list
3 - active filter = yes - fund source does not display
4 - active filter = no - fund source displays
5 - active filter = any - all display
6 - edit to re-activate fund source successful
7 - all active filters as expected

Revision history for this message
Lindsay Stratton (lstratton) wrote :

I have tested this code and consent to signing off on it with my name, Lindsay Stratton, and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Wishlist
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master along with some follow-ups:

- fix an issue with the schema update
- add release notes entry
- when creating a new funding source, default the active flag
  in the modal to checked
- disable actions to allocate from a funding source or
  apply credits to it if it is not active

Thanks, Tiffany and Lindsay!

Changed in evergreen:
milestone: none → 3.8-beta
assignee: Galen Charlton (gmc) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.