don't use primary for "a" css styling

Bug #1736967 reported by Rogan Hamby on 2017-12-07
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned

Bug Description

There are a number of things that could be done to make the CSS more customization friendly in Evergreen but this is the one I run into most often and that is the "a" element in var/templates/opac/css/style.ccs.tt2 (~ line 37) uses css_colors.primary

This causes issues when the the primary colors for the header and footer are set to the same color as the center background and you then end up with the same color on the same background and this effects trickles into links throughout the opac.

For a partial fix I'm thinking of adding an entry to templates/opac/parts/css/colors.tt2 for a_links with a default value of "#ffffff" to match stock but then make it easily customizable.

Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
Sam Link (slink-g) wrote :

Fix based on Roger's idea pushed here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/lp1736967_primary_a_css_fix

Since the Angular 2 update seems to pull css from the bootstrap-css-only package, I'm not sure if there's a need for an implementation there.

tags: added: pullrequest
Sam Link (slink-g) on 2019-03-01
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
importance: Undecided → Low
Michele Morgan (mmorgan) on 2019-03-07
Changed in evergreen:
milestone: none → 3.next
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers