missing pieces functionality broken in 3.0.1

Bug #1736269 reported by Andrea Neiman on 2017-12-04
32
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned

Bug Description

EG 3.0.1, web client

If you mark an item as Missing Pieces (either through the dedicated Missing Pieces interface or the right click Action Menu item in Check In), the prompts for set alert message & print patron letter do not appear.

Expected workflow:
1) Find a checked out item.
2) Set it to Missing Pieces
3) A Missing Pieces slip prints based on a template.
4) A modal appears prompting the creation of an Alert Message for the patron's account.
5) An option is given to print a templated letter to the patron
6) The item status is changed to Damaged [or whatever status is set by the OUS]

What happens in 3.0.1 is that after step 3, steps 4 & 5 are skipped with the following in console:

angular.js:14199 ReferenceError: $scope is not defined
    at item.js:888
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

The item status is still changed to Damaged.

Marking confirmed as this was initially reported by Angela Kilsdonk and confirmed by me.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Noting bug 1685929 as a likely culprit for the regression, as it was the only work done to Missing Pieces between 2.12.x and 3.0.1

Revision history for this message
Andrea Neiman (aneiman) wrote :

Description updated

---3) A Missing Pieces slip prints based
+++3) A Missing Pieces slip prints based on a template.

description: updated
Revision history for this message
Andrea Neiman (aneiman) wrote :

Noting for the record that this is still working correctly in the XUL client.

Changed in evergreen:
milestone: 3.0.3 → 3.0.4
Revision history for this message
Andrea Neiman (aneiman) wrote :

Adding that I missed a step in the expected functionality -- between steps 3 and 4 there should also be a step where the copy editor pops up in order for a note to be added to the copy in question.

Changed in evergreen:
milestone: 3.0.4 → 3.0.5
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.0.9
Revision history for this message
Rose Schooff (rschooff) wrote :

 #webstaffblocker

This bug is affecting our libraries to do their jobs properly.

Andrea Neiman (aneiman) on 2018-06-01
tags: added: webstaffblocker
Revision history for this message
Mike Rylander (mrylander) wrote :

I've pushed a branch to address this:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1736269-mark-missing-pieces

From the commit message:

In the work to separate the item service into a reusable component, a reference to $scope was left hanging around. This causes the service to die before it can complete its work. The code using $scope does seem to be necessary, so we'll have the function accept an outer_scope parameter and adjust the call sites.

tags: added: pullrequest
Revision history for this message
Cesar V (cesardv) wrote :
Andrea Neiman (aneiman) on 2018-06-08
tags: added: signedoff
Changed in evergreen:
milestone: 3.0.9 → 3.0.10
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Pushed to master, rel_3_0, and rel_3_1.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers