Release 2.12 should install nodejs from source

Bug #1736267 reported by Kathy Lussier on 2017-12-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned

Bug Description

In bug 1683388 and bug 1718549, we build nodejs from source so that Evergreen could keep up with newer versions. The code was applied to 3.0, but was not backported to 2.12 because we thought there wouldn't be significant web client in 2.12 to warrant this change. We are now getting errors when attempting to build the web client in 2.12 because we are using an older version of nodejs.

See the log at https://pastebin.com/n7cBknbg.

Cherry-picking the code from those two bugs fixed the issue in Ubuntu Trusty for me.

Working branch is forthcoming once I get an LP number.

Kathy Lussier (klussier) wrote :

A working branch with those cherry-picked commits is available at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1736267-install-nodejs-from-source-2-12

It works for me on Ubuntu Trusty, but I would prefer that more people look at it and/or test it on other distros before merging it to 2.12.

tags: added: pullrequest
Kathy Lussier (klussier) wrote :

Since Ben's code is working for me on Ubuntu Trusty, I've signed off on it and merged it to release 2.12 so that we can have the web client successful building on 2.12 again.

Thanks for your earlier work on this Ben and Galen!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers