The advanced search screen uses HTML valign attribute to format content

Bug #1735754 reported by Jane Sandberg
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

WCAG 2.0 G140 asks us to use CSS for formatting and HTML for structure (see https://www.w3.org/TR/WCAG20-TECHS/G140). Using the valign attribute of an HTML tag violates this rule. The valign attribute is used several times on the advanced search screen. I quickly checked what the display looks like with this attribute removed, and I noticed no differences in Firefox. Therefore, I propose that the valign attribute be removed throughout the advanced search page.

Shula Link (slink-g)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Shula Link (slink-g) wrote :
Revision history for this message
Shula Link (slink-g) wrote :
tags: added: pullrequest
Michele Morgan (mmorgan)
Changed in evergreen:
milestone: none → 3.next
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.next → 3.4-beta1
importance: Undecided → Low
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, jane and Sam!

I've elected not to bother backporting this one, since as far as I can tell, valign does absolutely nothing outside for tags used for HTML tables. I note, however, that we do still have a bunch of table tags (<tr>, <td>, etc.) using the valign attribute.

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.