web client Cannot delete multiple Items from Item Status Screen

Bug #1735539 reported by Robert J Jackson
78
This bug affects 17 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.0
Fix Released
High
Unassigned
3.1
Fix Released
High
Unassigned

Bug Description

web client 3.0

Just received report of (and confirmed) that when using Item Status to delete items from Evergreen web client by selecting all and then using Action menu and Delete Items only one item is actually deleted.

The resulting display contains duplicate entries of the selected non-deleted rows along with a single entry for the actually deleted item. I scanned in 4 item barcodes, made sure they were all checked and from the action pull down menu I selected delete items.

I am attaching screen shots showing the progress:

delete_item_status1 -> shows the 4 items to be deleted all selected
delete_item_status2 -> shows popup for what I assume is the only row deleted
delete_item_status3 -> shows the end results on the Item Status screen
delete_item_status4 -> shows verification of the one deleted item
delete_item_status5 -> shows item status screen with a fresh rescan of the items not deleted

Revision history for this message
Robert J Jackson (rjackson-deactivatedaccount) wrote :
Revision history for this message
Robert J Jackson (rjackson-deactivatedaccount) wrote :
Revision history for this message
Robert J Jackson (rjackson-deactivatedaccount) wrote :
Revision history for this message
Robert J Jackson (rjackson-deactivatedaccount) wrote :
Revision history for this message
Robert J Jackson (rjackson-deactivatedaccount) wrote :
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Beth Willis (willis-a) wrote :

I have confirmed this bug. The only thing I have to add is that it appears to be the last barcode scanned in that actually gets deleted.

tags: added: webstaffclient
Revision history for this message
Elaine Hardy (ehardy) wrote :

PINES libraries can also confirm this bug

Revision history for this message
Deborah Luchenbill (deborah) wrote :

Missouri Evergreen is also seeing this

Revision history for this message
Scott Thomas (scott-thomas-9) wrote :

PaILS confirms the existence of this bug.

Jason Boyer (jboyer)
Changed in evergreen:
importance: Medium → High
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Looks like the problem is in the item service's selectedHoldingsCopyDelete method. I've made a potential fix branch here:

working/user/dyrcona/lp1735339-item-status-delete-multi

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1735339-item-status-delete-multi

It also appears that this bug could potentially affect other interfaces.

Changed in evergreen:
milestone: none → 3.next
tags: added: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I'm removing the pullrequst tag for now. I believe that I can make it slightly more efficient and I want to make sure it still works when deleting 1 copy.

tags: removed: pullrequest
Revision history for this message
Jason Stephenson (jstephenson) wrote :

OK. That was quick. I've added the pullrequest back and pushed to a new branch that has the correct bug number in the name:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1735539-item-status-delete-multi

working/user/dyrcona/lp1735539-item-status-delete-multi

This one is 2 commits: the same commit from the original branch with a follow up to simplify the code a bit and remove an unnecessary step of copying the PCRUD search results into another array.

tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

After a suggestion from Mike Rylander in IRC (http://irc.evergreen-ils.org/evergreen/2018-04-13#i_355350), I added one more commit to use streaming instead of an atomic PCRUD call. This should handle large numbers of selected items better and allows us to add a progress meter in the future. I'm pretty sure that's it at this point.

It's still the branch from comment #12.

Changed in evergreen:
assignee: Jason Stephenson (jstephenson) → nobody
Revision history for this message
Jason Boyer (jboyer) wrote :

I've given this a look; deleted 1, 8, and 12 copies at once and everything worked as expected. Signoff (on last commit, but for all 3) here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1735539-item-status-delete-multi-signoff

working/jboyer/lp1735539-item-status-delete-multi-signoff

tags: added: signedoff
Dan Wells (dbw2)
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Revision history for this message
Dan Wells (dbw2) wrote :

Squashed and pushed to master, rel_3_1, and rel_3_0. Thanks, all!

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: 3.next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.