wishlist: add notices count + last notice date to Items Out screen

[Andrea Neiman]

Web Client

As funded by PaILS, Equinox has been commissioned to add two columns to the Patron Items Out interface: Total Notices (a count of total completed action/trigger events related to a loan); and Last Notice (the completion time of the last action/trigger event related to a loan).

Full functional specifications can be seen here:

https://yeti.esilibrary.com/dev/public/techspecs/add-notices.pdf

This development will shortly be in partner testing and a public branch is forthcoming.

[Cesar V (cesardv)]

Code branch for this is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1732275_add_notices_data_to_Patron_Itemsout

[Kathy Lussier (klussier)]

In my testing, I ran Concerto barcode CONC70000357 through the action trigger test for the Courtesy and 7-day overdue notice, and ran barcode CONC70000353 through the action trigger test for the Courtesy notice. All of the events show as complete in the database, and I can see those events listed in the event log for Concerto patron Mae Scott. However, I'm not seeing any values in the two new columns.

I'm not sure if there is a step I'm missing, but I can look at it later today if there something else I can try.

[Kathy Lussier (klussier)]

I also wanted to add that there are no error messages in the Console. I'll unassign myself in case someone wants to look at it.

[Galen Charlton (gmc)]

I've rebased the branch and added release notes and a test plan:

user/gmcharlt/lp1732275_review

Kathy, based on my testing, I suspect what happened is that the events were not yet complete; the new columns don't include pending events.

[Galen Charlton (gmc)]

Another thing to note - the new columns only count cases where the event definition is active... but the A/T test feature will happily create events even for event defs that are not marked active.

[Kathy Lussier (klussier)]

OK, thanks Galen! I'm pretty sure mind weren't active, which explain my results. Re-testing now!

[Kathy Lussier (klussier)]

Once I activated the action triggers, the counts worked correctly for me, both with and without the OU setting enabled. Merged for inclusion in 3.1!

Is there a reason why we only show this information if the action trigger is enabled? If the notice is sent to a patron, and the action trigger is subsequently set to disabled (maybe because of a policy change?), don't we still want to see whether or not the patron received a notice through the old definition?

I can post a follow-up bug, but first wanted to see if there was a reason for the current behavior.

Thanks Cesar, Galen and PaILS!

[Kathy Lussier (klussier)]

I filed the above-mentioned bug 1752674.