wishlist: add notices count + last notice date to Items Out screen

Bug #1732275 reported by Andrea Neiman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Web Client

As funded by PaILS, Equinox has been commissioned to add two columns to the Patron Items Out interface: Total Notices (a count of total completed action/trigger events related to a loan); and Last Notice (the completion time of the last action/trigger event related to a loan).

Full functional specifications can be seen here:

https://yeti.esilibrary.com/dev/public/techspecs/add-notices.pdf

This development will shortly be in partner testing and a public branch is forthcoming.

Revision history for this message
Cesar V (cesardv) wrote :
tags: added: pullrequest
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.1-beta
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Confirmed
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

In my testing, I ran Concerto barcode CONC70000357 through the action trigger test for the Courtesy and 7-day overdue notice, and ran barcode CONC70000353 through the action trigger test for the Courtesy notice. All of the events show as complete in the database, and I can see those events listed in the event log for Concerto patron Mae Scott. However, I'm not seeing any values in the two new columns.

I'm not sure if there is a step I'm missing, but I can look at it later today if there something else I can try.

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
Revision history for this message
Kathy Lussier (klussier) wrote :

I also wanted to add that there are no error messages in the Console. I'll unassign myself in case someone wants to look at it.

Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

I've rebased the branch and added release notes and a test plan:

user/gmcharlt/lp1732275_review

Kathy, based on my testing, I suspect what happened is that the events were not yet complete; the new columns don't include pending events.

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Another thing to note - the new columns only count cases where the event definition is active... but the A/T test feature will happily create events even for event defs that are not marked active.

Revision history for this message
Kathy Lussier (klussier) wrote :

OK, thanks Galen! I'm pretty sure mind weren't active, which explain my results. Re-testing now!

Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

Once I activated the action triggers, the counts worked correctly for me, both with and without the OU setting enabled. Merged for inclusion in 3.1!

Is there a reason why we only show this information if the action trigger is enabled? If the notice is sent to a patron, and the action trigger is subsequently set to disabled (maybe because of a policy change?), don't we still want to see whether or not the patron received a notice through the old definition?

I can post a follow-up bug, but first wanted to see if there was a reason for the current behavior.

Thanks Cesar, Galen and PaILS!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Kathy Lussier (klussier) → nobody
Revision history for this message
Kathy Lussier (klussier) wrote :

I filed the above-mentioned bug 1752674.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.