Web Client: Most Recent Transit is showing older transit

[Terran McCanna]

In 3.0.1:

On the Item Status page > Holds Transit tab > Most Recent Transit is displaying old transit information (possibly the first transit rather than the most recent?)

On the attached example, the item is currently in transit from STATELIB-L to NCLS-COVT (transit start date 11/3/2017). The previous transit was SGRL-VALDOSTA to STATELIB-L (transit start date 3/14/2017). But the one showing in the Most Recent Transit box is from STATELIB-L to ARL-ATH in 2015.

[Chris Sharp (chrissharp123)]

Branch that appears to fix the problem:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1729922_most_recent_transit_fix

[Galen Charlton (gmc)]

I've pushed an alternative patch to user/gmcharlt/lp1729922_most_recent_transit:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1729922_most_recent_transit

This patch takes a slightly more direct approach and fixes a problem where /all/ of the transits on the copy were fetched from the database, but only one was displayed. It also fixes an issue where transit receive time was not displayed.

[Chris Sharp (chrissharp123)]

Galen, your fix makes more sense and works for me:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1729922_most_recent_transit

[Jason Etheridge (phasefx)]

Looks good to me, pushed to master, thanks! Opening a followup bug for a minor worry I have with canceled transits.

[Jason Etheridge (phasefx)]

bug 1738688 for cross-reference

[Galen Charlton (gmc)]

This only made it into master, not rel_3_0, so I've now pushed it to rel_3_0. Fix will be available in 3.0.5.